Skip to content

Add a custom not-found page#357

Merged
TimHess merged 4 commits intomainfrom
not-found
Mar 3, 2025
Merged

Add a custom not-found page#357
TimHess merged 4 commits intomainfrom
not-found

Conversation

@TimHess
Copy link
Member

@TimHess TimHess commented Mar 3, 2025

Adds a 404 page to source and nginx config

@github-actions
Copy link

github-actions bot commented Mar 3, 2025

Preview link: https://docs-steeltoe-pr-357.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

Need to pair with a custom main site address?

A team member can use this az CLI command, replacing and for valid numbers:

az webapp config appsettings set --resource-group steeltoe --name docs-steeltoe --slot pr-<this-PR-number> --settings mainsite_host=https://www-steeltoe-pr-<other-pr-number>.azurewebsites.net

This is an automated message.

@TimHess TimHess marked this pull request as ready for review March 3, 2025 22:39
@TimHess TimHess merged commit 9283880 into main Mar 3, 2025
6 checks passed
@TimHess TimHess deleted the not-found branch March 3, 2025 22:52
Why Steeltoe
</button>
<div class="dropdown-menu" aria-labelledby="why">
<a class="dropdown-item" href="https://steeltoe.io/why-steeltoe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can't reuse the existing Razor component to render the menu, I think we should leave it out. This copy easily gets out of sync, resulting in more 404s. Causing a 404 on the 404 page is embarrassing.

The return link should just point to "https://docs.steeltoe.io/", which redirects to whatever version is current at that moment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost left a note in the description but figured I'd mention it at standup today... My first attempt here was to add a .md file so that we'd get everything in the docfx template, but the first attempt also came with the v4/v3/v2 menu. I was already planning to revisit this ASAP, during the docfx update

@TimHess TimHess mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants