For PR cleanup: collect output of slot deletion and delete GH env#143
Merged
For PR cleanup: collect output of slot deletion and delete GH env#143
Conversation
Member
Author
|
With the build failure, this is now definitely a problem for next week. We were already due for an update from the upstream initializr ui, now we might have to revisit the reverse-proxy situation too if this isn't solved by bumping deps: |
bart-vmware
reviewed
Feb 2, 2026
bart-vmware
approved these changes
Feb 2, 2026
Preview link: https://initializr-web-pr-143.azurewebsites.net
Need to pair with a custom InitializrService address?A team member can use this az CLI command, replacing and for valid numbers: az webapp config appsettings set --resource-group steeltoe --name initializr-web --slot pr-<this-PR-number> --settings "INITIALIZR_SERVICE_HOST=initializr-service-pr-<other-pr-number>.azurewebsites.net" "INITIALIZR_SERVICE_URI=https://initializr-service-pr-<other-pr-number>.azurewebsites.net/api/"
|
bart-vmware
approved these changes
Feb 3, 2026
Member
bart-vmware
left a comment
There was a problem hiding this comment.
I can't oversee the impact of the changed files, but the preview site works. Building and running locally works too, so I'm good with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SteeltoeOSS/Documentation#421