-
Notifications
You must be signed in to change notification settings - Fork 171
Improve management test coverage #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e4d814 to
6271345
Compare
ddfe948 to
a116aef
Compare
- Only display changed values from placeholder/decryption providers - Show placeholder/decryption providers *after* the configuration providers they wrap - Hide providers that don't have any properties
- Remove duplicate information in details for ASP.NET health checks - Fixed: X-Use-Status-Code-From-Response header not always respected - Fixed inconsistency in case-sensitivity of health group names
…s to matching namespace
…e all downstream dependencies are registered
… default exposure using Spring-style configuration keys - Fixed: remove duplicate entries in exposure over regular and Spring-style keys
5f7cdb2 to
5108fdd
Compare
- Order the returned list of endpoints by ID - Critical fix: block /cloudfoundryapplication and log warning when security middleware not added - Critical fix: don't turn off all security when the /cloudfoundryapplication hypermedia endpoint is turned off
5108fdd to
040a2c9
Compare
TimHess
reviewed
Jun 16, 2025
src/Management/src/Endpoint/Actuators/Environment/EnvironmentEndpointHandler.cs
Outdated
Show resolved
Hide resolved
bart-vmware
added a commit
to SteeltoeOSS/Documentation
that referenced
this pull request
Jun 16, 2025
bart-vmware
added a commit
to SteeltoeOSS/Documentation
that referenced
this pull request
Jun 16, 2025
This was referenced Jun 16, 2025
TimHess
previously approved these changes
Jun 16, 2025
Member
TimHess
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, just a couple small items that could be addressed
src/Management/test/Endpoint.Test/Actuators/CloudFoundry/CloudFoundryActuatorTest.cs
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/Loggers/LoggersActuatorTest.cs
Outdated
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/Refresh/TestConfigurationSource.cs
Show resolved
Hide resolved
TimHess
approved these changes
Jun 16, 2025
bart-vmware
added a commit
to SteeltoeOSS/Documentation
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component/Management
Issues related to Steeltoe Management (actuators)
ReleaseLine/4.x
Identified as a feature/fix for the 4.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves test coverage of the Steeltoe actuator endpoints by running tests against host builders and asserting on full JSON response bodies. While doing so, several bugs were fixed.
Related PR to update the documentation can be found at SteeltoeOSS/Documentation#386.
cloudfoundryapplication endpoint
Refactor tests for cloudfoundryapplication endpoint
dbmigrations endpoint
Refactor tests for dbmigrations endpoint
env endpoint
Refactor tests for env endpoint
Hide providers that don't have any properties(reverted for Spring Boot compatibility)health endpoint
Refactor tests for health endpoint
X-Use-Status-Code-From-Responseheader not always respectedheapdump endpoint
Refactor tests for heapdump endpoint
threaddump endpoint
Refactor tests for threaddump endpoint
httpexchanges endpoint
Refactor tests for httpexchanges endpoint
IHttpExchangesRepositorywithIHttpExchangeRecorder, so that filtering logic becomes testableoptions.IncludeTimeTakenwas ignoredDiagnosticObserverHttpExchangeRecorderdoesn't failhypermedia endpoint
Refactor tests for hypermedia endpoint
info endpoint
Refactor tests for info endpoint
git.propertiesfile that contain = character in their valueloggers endpoint
Refactor tests for loggers endpoint
refresh endpoint
Refactor tests for refresh endpoint
mappings endpoint
Refactor tests for mappings endpoint
beans endpoint
Refactor tests for beans endpoint
all endpoints
Spring Boot Admin
Other
Fixes #1028.
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.