Skip to content

Conversation

@bart-vmware
Copy link
Member

Description

Update places where BindConfiguration is called, which registers anonymous delegates, and is thus not safe to be called multiple times.

With a pre-check in place, several Try* methods behind it can be replaced for efficiency, but only if:

  • The implementation is an internal type and does not implement a public interface
  • The implementation type is not shared between Steeltoe components

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

…ymous delegates, and is thus not safe to be called multiple times.

With a pre-check in place, several Try* methods behind it can be replaced for efficiency, but only if:
- The implementation is an internal type and does not implement a public interface
- The implementation type is not shared between Steeltoe components
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 85.6% 79.8%
Steeltoe.Common.Certificates 96.2% 85.2%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 41.6%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 98.5% 92.6%
Steeltoe.Configuration.CloudFoundry 99.1% 91.8%
Steeltoe.Configuration.ConfigServer 97.2% 91.6%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.4% 95.4%
Steeltoe.Connectors 93.9% 89.4%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 92.3% 100%
Steeltoe.Discovery.Consul 98.1% 95.2%
Steeltoe.Discovery.Eureka 91.9% 84.8%
Steeltoe.Discovery.HttpClients 94.2% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.5% 89.1%
Steeltoe.Management.Prometheus 95.9% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.3% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@bart-vmware bart-vmware marked this pull request as ready for review October 23, 2025 14:38
@bart-vmware bart-vmware requested a review from TimHess October 23, 2025 14:38
@bart-vmware bart-vmware merged commit 0f06725 into main Oct 23, 2025
21 of 23 checks passed
@bart-vmware bart-vmware deleted the fix-bind-configuration branch October 23, 2025 15:41
@bart-vmware bart-vmware added Component/Configuration Issues related to Configuration providers Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Dec 15, 2025
@bart-vmware bart-vmware added this to the 4.1.0 milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component/Configuration Issues related to Configuration providers Component/Discovery Issues related to Steeltoe Service Discovery ReleaseLine/4.x Identified as a feature/fix for the 4.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants