Skip to content

Conversation

@overcat
Copy link
Member

@overcat overcat commented Mar 27, 2025

No description provided.

…ment_to_contract_op` fails when the sender's account is the same as the asset issuer's account.
@overcat
Copy link
Member Author

overcat commented Mar 27, 2025

Thanks to @tamirms for pointing this out. https://github.com/stellar/go/pull/5642#discussion_r2015043692

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (c8045a4) to head (424980b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         262      262           
  Lines       14228    14250   +22     
=======================================
+ Hits        13982    14004   +22     
  Misses        246      246           
Flag Coverage Δ
unittests 98.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
stellar_sdk/transaction_builder.py 98.59% <100.00%> (+<0.01%) ⬆️
tests/test_transaction_builder.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@overcat overcat merged commit 3527998 into main Mar 27, 2025
53 checks passed
@overcat overcat deleted the fix-send branch April 11, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants