Skip to content

Move printing of system info out of StelLogger#4139

Merged
10110111 merged 1 commit intomasterfrom
format-log
Feb 17, 2025
Merged

Move printing of system info out of StelLogger#4139
10110111 merged 1 commit intomasterfrom
format-log

Conversation

@10110111
Copy link
Copy Markdown
Contributor

Description

Logger has no business printing out system info. Besides, this info appears before the log header, which is one more reason to split this off and call this code after the header has been printed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@alex-w
Copy link
Copy Markdown
Member

alex-w commented Feb 17, 2025

Probably naming StelSystemInfo.[cpp|hpp] will better (consistence with other file names)

@github-actions
Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 25.1 milestone Feb 17, 2025
@10110111 10110111 merged commit 048c361 into master Feb 17, 2025
@10110111 10110111 deleted the format-log branch February 17, 2025 12:38
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Feb 24, 2025
@github-actions
Copy link
Copy Markdown

Hello @10110111!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 23, 2025
@github-actions
Copy link
Copy Markdown

Hello @10110111!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants