Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
I’m not sure that this patch is necessary - why HTML formatted text is important for you? |
Because there are subscripts that are lost on |
|
HTML sounds nice to keep titles&subscripts, yes. But I'm also not sure about the color necessity. For stars the color is derived from B-V, or a custom color can override the automatically derived ones, ... probably "current color and current font" is enough for the editor (sorry, is "LibO==LibreOffice?) Or do you fear glyphs may get lost if font name is not given? |
|
I think the text should be black :) |
Yes.
No, it's just a matter of completeness. Seems to make sense to preserve font if we do preserve colors. It's just a bit strange to see colored text that suddenly got serifs that weren't present in the Stellarium window.
Ideally, the color shouldn't be defined if we decide not to preserve the colors, so that the editor's current color could take effect. |
Currently I see white text on white background - this is not very good combination for reading :) |
Sure, because we are preserving the colors. If we decide not to, we shouldn't force it to be black either, because it's not our design choice then, we should simply omit the font color and let the editor use what it would if you type. In the current case we could just strip |
|
Add stripping color data is good IMHO |
In addition to current plain text being copied into clipboard on Ctrl+Shift+C, this patch also provides an HTML version, so that one could paste it e.g. into LibO Writer and get bold fonts, subscripts etc.
664d322 to
b6234af
Compare
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @10110111! Please check the latest stable version of Stellarium: |
In addition to current plain text being copied into clipboard on Ctrl+Shift+C, this patch also provides an HTML version, so that one could paste it e.g. into LibO Writer and get bold fonts, subscripts etc.
I'm not sure though that we want to keep the text color. It's very pale when pasted into LibO Writer with white background, but OTOH, I remember that copying from web browser also preserves the colors. We don't specify the font explicitly though, so it doesn't match after pasting. If we preserve the color, maybe we could wrap the HTML into one more
<font>tag for font name.Type of change
How Has This Been Tested?
Test Configuration:
Checklist: