Skip to content

Single language box for whole program#4445

Merged
alex-w merged 1 commit intomasterfrom
gui/language-box
Aug 8, 2025
Merged

Single language box for whole program#4445
alex-w merged 1 commit intomasterfrom
gui/language-box

Conversation

@alex-w
Copy link
Copy Markdown
Member

@alex-w alex-w commented Aug 7, 2025

Description

Using single language box for whole program

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 7, 2025

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

Copy link
Copy Markdown
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, thanks.
The GUI combobox (plus its store button) might even be moved to group "Default settings" to save a bit of screen space.

@alex-w alex-w added this to the 25.3 milestone Aug 8, 2025
@alex-w alex-w added this to GUI Aug 8, 2025
@github-project-automation github-project-automation bot moved this to Backlog in GUI Aug 8, 2025
@alex-w alex-w merged commit 693cb41 into master Aug 8, 2025
31 checks passed
@alex-w alex-w deleted the gui/language-box branch August 8, 2025 04:23
@github-project-automation github-project-automation bot moved this from Backlog to Done in GUI Aug 8, 2025
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Aug 19, 2025
@github-actions
Copy link
Copy Markdown

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 29, 2025
@github-actions
Copy link
Copy Markdown

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants