Conversation
* Switched to bundel MSVC Added windows mingw to ci * Fixed vcpkg install * Update bundle-build.yml * Fixed workflows * Swichted to poweshell & vcpkg not requiered * Removed windows ci * Added new icons * Revert "Added new icons" This reverts commit 9ff982a. * Update bundle-build.yml * Removed zipped does not work * Update bundle-build.yml * don't create a desktop icon
…figure-lines feat: eraser for stick figure lines (#56)
|
omega Cen was the case for which we introduced it |
|
Yes, for the stick figure. But do you have some artwork texture that cannot be successfully linked with neighbouring stars? |
|
ah! artwork ...there, I think, I don't really care because artworks has many points (pixels) more than stickfigures |
|
Hey everybody! First, @xLPMG, thank you very much for all your work implementing so much of the feedback in this PR. @gzotti @10110111 @alex-w, thank you as well for gathering feedback and helping make the plugin even better while aligning it with the current Stellarium. @sushoff, we also appreciate your active participation in the discussions related to this PR. Overall, the developer team considers this project complete. This started as a university project to demonstrate team workflows using agile methods, and I’m proud to say we’ve achieved that with excellent results. We knew some work might be needed after creating the PR for the master repository, but now we are reaching the end. @10110111, we will not implement merging line segments into polylines, as this would require significant refactoring of something that already works well for us. Of course, you three are the maintainers and have the final word, but we will not be investing additional time in this. @sushoff, from our side, there will not be any further meetings to improve the plugin or documentation. None of us have the capacity to continue work on this project. Stellarium for us has been, and continues to be for many others, a highly practical and useful software for education, hobbyists, and researchers. We appreciate the work behind it and hope it continues to be maintained and expanded for many years to come. However, as none of us work in this field and this began purely as a university project, our resources are now exhausted. Regarding the remaining conversation items (aside from the polylines), the last issues seems to be:
I haven't looked at this precisely, but it sounds like more than a minor adjustment. Including specific formatting is likely to take more than a few minutes. And the other:
@sushoff, as my colleague mentioned, none of us encountered these issues. If they are infrequent, this might have been a misunderstanding, and that should be acceptable. We hope you understand our perspective. Please comment if you have any objections or concerns. With this, we officially signal the end of our work on this plugin. I am still reachable, will keep an eye on the conversation of the PR, and will stay involved in the conversation. Best regards and thanks from all of us: @Integer-Ctrl, @MherMnatsakanyan03, @RivinHD, @xLPMG, and @ZeyxRew |
|
I know, the semester ends in Jena - and marks are given (I guess) as I am neither employed in Jena nor paid for teaching nor involved in grading, I can only thank you all for your work |
|
It's a pity you jump off deck days before release. :-( But we should not mourn. I know, busy semesters etc., still thank you for probably a good addition with potential to become important and long-lasting (not just a semester). Susanne and her peers need it urgently (and hopefully new students will continue), so I still am positive about a merge, even if it does not completely fulfill our own wishes. After all, it does not break anything AFAICS. As in most minority plugins, the default installation state should be "plugin not activated".
I just tried the raster linker. It works, at least somehow, unfortunately not with an image preview. I just chose some FullHD color PNG image I had lying around. I can move the three green dots in my image preview, select stars in the sky, and save the result. For whatever reason, the texture is then not displayed, though. The logfile says nothing. I don't see an issue in the JSON. Does anyone has success with that? All in all, the plugin does something, but maybe the final result should still be checked by the SC author to make it compliant with the specs in the User Guide. |
There were none, but I asked for this change because of 1) it's like so in the example in the SC repo, 2) it looks better, and 3) it should be a trivial change in the code.
It would be not good at all if it emits a completely wrong chapter structure. For me this is a major issue, since the emitted document will be used by the SC authors as a reference that's supposed to follow all guidelines. |
|
OK, the bad structure is an issue to be solved ASAP (for 25.4) by one of us or by the next developer group if there is one. I was not aware that the structure was so critically important. Anyhow, I read the authors won't do it. I doubt you will be flooded with ill-formatted SCs now, however. Silent inclusion in 25.3 should allow an uncomplicated user test run for @sushoff 's peers. If she instructs them that they must fix the text after creation (and do it), it's OK for me. We could put up a note in their plugin startup page: NOTE: Test only. The result does not yet comply to Stellarium's formatting rules. |
|
With this warning it's OK to me.
…On Sun, 21 Sep 2025, 00:27 Georg Zotti, ***@***.***> wrote:
*gzotti* left a comment (Stellarium/stellarium#4454)
<#4454 (comment)>
OK, the bad structure is an issue to be solved ASAP (for 25.4) by one of
us or by the next developer group if there is one. I was not aware that the
structure was so critically important. Anyhow, I read the authors won't do
it. I doubt you will be flooded with ill-formatted SCs now, however. Silent
inclusion in 25.3 should allow an uncomplicated user test run for @sushoff
<https://github.com/sushoff> 's peers. If she instructs them that they
must fix the text after creation (and do it), it's OK for me. We could put
up a note in their plugin startup page: *NOTE: Test only. The result does
not yet comply to Stellarium's formatting rules.*
—
Reply to this email directly, view it on GitHub
<#4454 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQU3MRO7YJ7O2CSWM3CVRL3TV6ABAVCNFSM6AAAAACD5YSDR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJVGA4DOOJVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you for not giving up on this PR :) Anyway, would it be possible to create a project for this plugin in the Stellarium repo? Then we could copy some of the leftover tickets from our fork and create new tickets for the critical issues you mentioned in this PR. I suppose after this PR is merged, we will delete our fork and with it all the remaining open feature requests... |
|
Well, once it's merged it is part of master. "Tickets" (called issues here) should be deposited in the main repo then. Maybe mark them SCM:... in the issue title for easier identification. @alex-w and @10110111 , this is a big PR with 249 commits. The authors will abandon work. IMHO it's OK to squash this to one commit, unless someone of you wants to do code archaeology. After merge, we will have to do some immediate improvements for 25.3 (this warning and editing hints.). |
|
OK to squash for me |
|
@xLPMG just to be sure: Did texture linking work for you? |
I tried it right now and it works for me. If the image is not shown immediately, try moving the anchor points around in the preview to make it become visible. I dont know the details, but if the image is distorted in a weird way, it might not be shown at all. |
|
Ah yes, now it worked, with a real example. OK, not "any" triangle works then. |
It's new code, so OK to squash. |
|
thank you all ... this release falls into my most busy week of the month, so I was distracted by other urgent duties. as you all know, I am always busy to not overcharge people and to look for support for all of you (good people need to be protected). Just to clarify @gzotti: as I had told you orally, I am not the supervisor of this student developing project (only the product owner); I will ask the dear former colleagues if they want to continue this in winter term.
|
|
I have just modified the description wizard panel. I hope the result is now in line with the description.md format specified by @10110111 in SUG section 9.1:
@sushoff I suggested you will hopefully provide the section in the SUG for 25.4 because you and your peers are the ones who are going to use the plugin. |
Just make a real new line in the XML (or, I suppose, paste a newline into the Designer's input field for the placeholder). I've pushed this fix. |
alex-w
added
the
state: published
|
Hello @Integer-Ctrl! Please check the fresh version (development snapshot) of Stellarium: |
alex-w
removed
the
state: published
|
Hello @Integer-Ctrl! Please check the latest stable version of Stellarium: |
@sushoff thanks for the idea and the effort. A recurring issue that I have observed over and over in my lifetime as software engineer is that many developers (including former professional colleagues) think that documentation is not part of the process/branch; "someone else will deal with it...". A bare minimum dev effort should be to include some skeleton plugin section in the UG. A branch should not be merged as long as no minimal UG entry was made. Because now the average user had no idea how to use this plugin. Meanwhile users could be directed to https://github.com/Stellarium/stellarium/blob/master/plugins/SkyCultureMaker/README.md ? Maybe add that link in the plugin info screen? |
|
Where can I find |
|
I tried this plugin and it works well. However, I don't seem to have found the feature for naming celestial bodies. How can I assign local names to stars and planets? |
Ouch... missing feature :( Please fill the feature request |
If you care to dig deeper into the plugin discussion, you find the plugin is not yet to be used by the average user (Therefore the warning in the welcome screen) and therefore has not been presented in the SUG foreword. Consider it public beta for personally invited users. |
11 participants
Description
Sky Culture Maker is a plugin for Stellarium, designed to simplify the creation and customization of sky cultures. With this tool, users can easily define new sky cultures, draw constellations, and visualize their arrangements directly within Stellarium.
The plugin provides an intuitive interface for both amateur astronomers and advanced users to:
.fabdata into JSONDependencies
Maker
Converter
Type of change
How Has This Been Tested?
This plugin was developed as part of a university project with five active contributors. We followed a collaborative development process with frequent code reviews and functional testing across team members. The changes were tested manually on Linux, Windows, and macOS to ensure cross-platform compatibility.
Checklist: