Skip to content

GUI: Fix font change#4509

Closed
gzotti wants to merge 2 commits intomasterfrom
gui/font-reload
Closed

GUI: Fix font change#4509
gzotti wants to merge 2 commits intomasterfrom
gui/font-reload

Conversation

@gzotti
Copy link
Copy Markdown
Member

@gzotti gzotti commented Sep 11, 2025

Description

StelApp is the only element which ever accepts a font change.
Currently, several StelModules have their own fonts which may get initialized at startup, but then only size was changed.

When switching font, the font change should become effective immediately, not only after relaunch.

This is a first step to hopefully fix the font issues which appeared with Skycultures demands.

This branch should be used to

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: Windows 11
  • Graphics Card: irrelevant

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti gzotti added this to the 25.3 milestone Sep 11, 2025
@gzotti gzotti self-assigned this Sep 11, 2025
@gzotti gzotti added the enhancement Improve existing functionality label Sep 11, 2025
@gzotti gzotti added this to GUI Sep 11, 2025
@gzotti gzotti added the importance: high Obvious error, very annoying, but no crash label Sep 11, 2025
@github-project-automation github-project-automation bot moved this to Backlog in GUI Sep 11, 2025
@github-actions github-actions bot requested review from 10110111 and alex-w September 11, 2025 16:22
@github-actions
Copy link
Copy Markdown

Hello @gzotti!

Thank you for the suggested improvement.

@github-actions
Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@gzotti
Copy link
Copy Markdown
Member Author

gzotti commented Sep 11, 2025

(git messup with upper/lowercase branch name. Closing this, coming back in other PR...)

@gzotti gzotti closed this Sep 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in GUI Sep 11, 2025
@alex-w alex-w deleted the gui/font-reload branch September 12, 2025 07:18
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 17, 2025
@github-actions
Copy link
Copy Markdown

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 29, 2025
@github-actions
Copy link
Copy Markdown

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve existing functionality importance: high Obvious error, very annoying, but no crash

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants