Skip to content

Expanding AstroCalc/Almanac tool#4516

Merged
alex-w merged 3 commits intomasterfrom
astrocalc/almanac-today
Sep 15, 2025
Merged

Expanding AstroCalc/Almanac tool#4516
alex-w merged 3 commits intomasterfrom
astrocalc/almanac-today

Conversation

@alex-w
Copy link
Copy Markdown
Member

@alex-w alex-w commented Sep 14, 2025

Description

The section "Today" in AstroCalc/Almanac tool has been expanded:

Note: twilight finder use for computation sunrise/sunset time in InfoBox and for actions to jump to these times via shortcuts

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot requested review from 10110111 and gzotti September 14, 2025 09:18
@alex-w alex-w added this to the 25.3 milestone Sep 14, 2025
@alex-w alex-w added this to AstroCalc Sep 14, 2025
@github-project-automation github-project-automation bot moved this to Backlog in AstroCalc Sep 14, 2025
@alex-w alex-w added the subsystem: astrocalc The issue is related to AstroCalc subsystem of planetarium... label Sep 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 14, 2025

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w moved this from Backlog to In review in AstroCalc Sep 14, 2025
alex-w and others added 3 commits September 15, 2025 13:09
… custom altitude (fix #4467)

Note: twilight finder use for computation sunrise/sunset time in InfoBox and for shortcuts

Visual fixes

Fix indentation

Fix indentation

Update AstroCalcAlmanacWidget.hpp
Update AstroCalcAlmanacWidget.cpp
@alex-w alex-w force-pushed the astrocalc/almanac-today branch from 7108194 to c5c3b42 Compare September 15, 2025 06:09
@alex-w alex-w merged commit f1abc08 into master Sep 15, 2025
30 of 31 checks passed
@alex-w alex-w deleted the astrocalc/almanac-today branch September 15, 2025 06:12
@github-project-automation github-project-automation bot moved this from In review to Done in AstroCalc Sep 15, 2025
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Sep 17, 2025
@github-actions
Copy link
Copy Markdown

Hello @alex-w!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 29, 2025
@github-actions
Copy link
Copy Markdown

Hello @alex-w!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: astrocalc The issue is related to AstroCalc subsystem of planetarium...

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Specific time: Minutes before sunrise/after sunset astrocal almanac: include custom solar altitude of twilight finder

2 participants