Fix GravityLabels with mixed-directional labels (and higher-level Unicode)#4519
Merged
Fix GravityLabels with mixed-directional labels (and higher-level Unicode)#4519
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
Member
Author
4e45441 to
2d38a48
Compare
Member
Currently 25.4... |
Member
Author
|
I know. I did not expect to have a solution by yesterday. A few comments can still be cleaned up, but else it seems to work OK. It also does not provide new translatable strings. |
alex-w
approved these changes
Sep 20, 2025
- multipart labels in LTR order also for RTL languages
4624ca3 to
2277f4a
Compare
|
Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @gzotti! Please check the latest stable version of Stellarium: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The multipart cultural label causes problems with gravityLabels when
TODO:
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: