Skip to content

minor dynamic resolution changes #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
10110111 merged 4 commits into from
Dec 2, 2025
+13 −4
Merged

minor dynamic resolution changes #4672

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88b8134
minor dynamic resolution changes
uwes-ufo Nov 27, 2025
04078bb
comments
uwes-ufo Dec 2, 2025
5d5e03c
unintentional changes removed
uwes-ufo Dec 2, 2025
88abeed
align comments
uwes-ufo Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/core/modules/AtmosphereShowMySky.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,8 +629,15 @@ Vec4f AtmosphereShowMySky::getMeanPixelValue()

bool AtmosphereShowMySky::dynamicResolution(StelProjectorP prj, Vec3d &currPos, int width, int height)
{
if (!flagDynamicResolution)
return false;
if (!flagDynamicResolution) // There's nothing to do here, we're drawing
return false; // in full resolution and full frame rate.

// If the scene is rendered in real time and is practically static,
// Stellarium generates approximately 18 frames per second.
// We draw about one atmosphere per second at full resolution.
// For faster-moving scenes, Stellarium increases the frame rate to the maximum,
// perhaps 50 frames per second depending on the hardware's capabilities.
// We draw about 10 atmospheres per second in reduced resolution.

const auto currFov=prj->getFov(), currFad=fader.getInterstate();
Vec3d currSun;
Expand All @@ -651,16 +658,15 @@ bool AtmosphereShowMySky::dynamicResolution(StelProjectorP prj, Vec3d &currPos,
dynResTimer--; // count down to redraw
return true;
}
// if there is a timeout, we draw with full resolution
// if the change is too large, we draw with reduced resolution
atmoRes=timeout?1:reducedResolution;
// if the change is too big, we draw with reduced resolution, otherwise with full resolution
Copy link
Contributor

@10110111 10110111 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, the previous comment was a bit more understandable. I think the following would be better:

If the change is too big, the scene is considered dynamic and needs a higher frame rate, so it's rendered in lower resolution. Otherwise there's been a timeout, so the scene is updated in full resolution.

Copy link
Contributor Author

@uwes-ufo uwes-ufo Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4672 (comment)

atmoRes=changed?reducedResolution:1;
if (prevRes!=atmoRes)
{
resizeRenderTarget(width, height);
qCDebug(Atmo) << "dynResTimer" << dynResTimer << "atmoRes" << atmoRes << "changeOfView" << changeOfView.norm() << changeOfView;
}
// At reduced resolution, we hurry to redraw - at full resolution, we have time.
dynResTimer=timeout?17:5;
dynResTimer=changed?5:17; // dynResTimer is like a clock divider.
prevRes=atmoRes;
prevFov=currFov;
prevFad=currFad;
Expand Down
Loading