Merged
Conversation
Now users will edit an actual list of references: a QTreeWidget, not having to deal with the Markdown syntax we use.
d4673b7 to
2bc2e4f
Compare
alex-w
approved these changes
Dec 6, 2025
Contributor
Hm on my system they do: (although very minor, but the goal should be no warnings :) ) I'm not sure if this is a good practice, but one way to get rid of this is to not name the parameters: |
Member
|
You can use Q_UNUSED(param_not_used_elsewhere_in_body) to make it clearer. |
Contributor
Author
Fixed in f180b2a. |
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @10110111! Please check the latest stable version of Stellarium: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now users will edit an actual list of references: a
QTreeWidget, not having to deal with the Markdown syntax we use. This way we'll hopefully get a higher rate of syntactically correct SCs in new PRs.Type of change
How Has This Been Tested?
Test Configuration:
Checklist: