Fix win11 arm64 by gzotti · Pull Request #4776 · Stellarium/stellarium

gzotti · 2026-02-17T00:12:50Z

Description

This shall include fixes identified during testing work on Arm64 hardware donated by Microsoft.

Apart from the tests listed in #4772, getting ASCOM to play nice seems the largest issue. :-(

Fixes #4772 (issue)

Screenshots (if appropriate):

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
This change requires a documentation update
Housekeeping

How Has This Been Tested?

Test Configuration:

Operating system: Windows 11 on ARM64 25H2
Graphics Card: Qualcomm Adreno X1-85

Checklist:

My code follows the code style of this project.
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (header file)
I have updated the respective chapter in the Stellarium User Guide
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

github-actions · 2026-02-17T00:13:32Z

Great PR! Please pay attention to the following items before merging:

Files matching guide/**:

Did you remember to update screenshots to match new updates?
Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

10110111

So this doesn't seem to "fix" anything, just tweaks logging and the docs. Am I missing something?

10110111 · 2026-02-17T02:26:51Z

plugins/TelescopeControl/src/common/ASCOMSupport.cpp


 	initResult = OleInit(COINIT_APARTMENTTHREADED);
-	hResult = OleCreateInstance(L"ASCOM.Utilities.Util", &utilDispatch);
+        hResult = OleCreateInstance(L"ASCOM.Utilities.Util", &utilDispatch);


Why this change to spaces?

I have loaded the .clang-format file now. When I select a region and right-click "Auto-Indent Selection", there are tabs at the head of lines. As soon as I store the file, there are space characters. Same nonsense on every new system, and doing this only once per year I have forgotten the switches. :-( Will find out.

BTW, is .clang-format or still the older xml file the right? Why are there both? Could we delete one?

BTW, is .clang-format or still the older xml file the right? Why are there both? Could we delete one?

In Ubuntu 22.04 the qtcreator package is still v6.0.2, which needs an XML file. Modern QtCreator (that I built from sources) wants a clang-format file. So we need both. (And ideally, also update the Coding Style docs to include the clang-format file, in addition to the XML.)

OK, then we need both, yes, and I hope they are equal in rules. (My 2012 laptop must stay on U22.04LTS until 2032 or until nouveau supports a Geforce 580...)
Just the auto-conversion from tab to space on store is annoying, I must find the relevant switch.

plugins/TelescopeControl/src/common/ASCOMSupport.cpp

10110111 · 2026-02-17T02:34:02Z

getting ASCOM to play nice seems the largest issue

If you have access to the actual hardware, could it be better to switch to Alpaca and drop the COM-based ASCOM? This would bring support for these devices to Linux (and possibly macOS).

gzotti · 2026-02-17T08:51:51Z

Please ignore this PR for now. It is a draft, mostly used for exchanging between two systems. Yes, spacing is off, I had not installed the style file on the new system. Yes, Alpaca would be nice, but see other PR, need deeper insight into Stellarium's underdocumented TelescopeControl plugin. In just these days it may even be an issue between MS and ASCOM with some problems in .NET3.5.

The ARM64 is the first system where I need scaling !=1. On startup the main window is shrinking. This fix prevents the shrinking. If it breaks elsewhere, enclose in WIN32.

gzotti · 2026-02-18T09:22:44Z

Of course, if anyone has time/knowledge to go into Alpaca (which works on all platforms), the relevant branch #4148 is rebased and open for continuation.

gzotti · 2026-02-22T21:12:45Z

With some help from the ASCOM developers we found that we need a sidecar file stellarium.exe.config to be installed next to stellarium.exe:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <startup useLegacyV2RuntimeActivationPolicy="true">
    <supportedRuntime version="v4.0"/>
    <supportedRuntime version="v2.0.50727"/>
  </startup>
</configuration>

Where should this go in the repo (inside ASCOM sources?), and how do I ensure it is being copied to the install folder? In addition, apparently this use of ASCOM based on .NET requires a signed program to run without interference of 'Smart App Control'.

I am in the process of upgrading qDebug() etc into qCDebug(Telescopes) and decide what's debug and what's a warning, but this should go into all parts of the plugin, will take a few days longer. We can then finetune also this plugin, with qCWarning as default.

alex-w · 2026-02-22T21:45:46Z

@gzotti it’s an easy - please see similar files in data directory + iss files in cmake directory (of course if you want to put this file when telescope control plugin is enabled then you need to update CMakeLists.txt file too)

gzotti · 2026-02-22T22:14:21Z

Now I am back at the coding style issue. Using the .clang-format, indentation works with tabs. When I store the file, tabs are replaced by 8 spaces. Where is the switch to fix that nonsense?

EDIT: Bah, found it. Preferences/Text Editor/Cleanups Upon Saving. Disable "Clean indentation".

…COM.

- logging categories - separate debug from warnings - More diagnostics.

alex-w · 2026-02-23T00:11:04Z

EDIT: Bah, found it. Preferences/Text Editor/Cleanups Upon Saving. Disable "Clean indentation".

Hmm… Should be xmi file updated too?

alex-w · 2026-02-23T00:12:39Z

@gzotti I fear patch for stellarium.exe.config should be a bit different

10110111 · 2026-02-23T02:27:39Z

Should be xmi file updated too?

What do you mean? The XML is short and to the point. "Cleaning" is a separate config option (rather stupid in that it doesn't follow the coding style configuration).

10110111 · 2026-02-23T02:38:05Z

How can we refer to the .clang-format file in doc/codingConventions.doxygen without having to maintain a copy of it in the doc directory, but having it available on the website?

gzotti · 2026-02-23T09:16:31Z

@gzotti I fear patch for stellarium.exe.config should be a bit different

I know. The file is where we said, but the copying to destination is not there yet.

gzotti · 2026-02-23T09:25:41Z

How can we refer to the .clang-format file in doc/codingConventions.doxygen without having to maintain a copy of it in the doc directory, but having it available on the website?

Do we need to actually show its contents? Else, a link to Github should suffice. But a notice esp. also in the BUILDING instructions for newcomers that in addition to this file being used by QtCreator, developers must also disable the switch mentioned above. This is more a QtCreator issue, but we have to live with it. When the last LTS version that depends on the old XML style file is EOL, we can at least remove that one.

gzotti · 2026-02-23T15:32:55Z

Thanks. But IMHO it should be behind "if ENABLE_PLUGIN TelescopeControl and ASCOM" (or something similar that works :-).

gzotti · 2026-02-23T15:38:13Z

I think the AppVeyor for Windows (all flavours) could be upgraded to Qt6.10 if possible. On Windows the libraries are packed with the program, so we can take the latest.

alex-w · 2026-02-23T15:57:36Z

Thanks. But IMHO it should be behind "if ENABLE_PLUGIN TelescopeControl and ASCOM" (or something similar that works :-).

Yes, we can do it, but I'm not sure that we need overengineering here...

alex-w · 2026-02-23T16:01:24Z

What do you mean? The XML is short and to the point. "Cleaning" is a separate config option (rather stupid in that it doesn't follow the coding style configuration).

I mean should we update stellarium-ide.xml file or not?

alex-w · 2026-02-23T16:07:22Z

I think the AppVeyor for Windows (all flavours) could be upgraded to Qt6.10 if possible. On Windows the libraries are packed with the program, so we can take the latest.

You can try it

P.S. You want to drop support 32-bit (Qt5) packages?

10110111 · 2026-02-23T16:09:05Z

I mean should we update stellarium-ide.xml file or not?

No, it's completely correct.

I've updated the relevant docs (see 1035111).

gzotti · 2026-02-23T16:52:26Z

P.S. You want to drop support 32-bit (Qt5) packages?

I thought we had dropped 32bit Windows with the new star catalog? At least there is no download for it, right? Actually, the ARM-related changes should not affect Qt5 builds. (Maybe the config file is useful also here.) I meant, all Appveyors now running Qt6.8 (or lower?) could be updated to 6.10 if possible. I'll try...

alex-w · 2026-02-23T17:31:04Z

P.S. You want to drop support 32-bit (Qt5) packages?

I thought we had dropped 32bit Windows with the new star catalog? At least there is no download for it, right? Actually, the ARM-related changes should not affect Qt5 builds. (Maybe the config file is useful also here.) I meant, all Appveyors now running Qt6.8 (or lower?) could be updated to 6.10 if possible. I'll try...

No, we still publish win32 packages. The current branch can’t be compiled with Qt5 (type conversion issues).

P.S. Maybe it’s time to drop support win32 packages (W7+), but we should resolve issues for compilation with Qt5.

P.P.S. Qt 6.8+ requires Windows 10+.

gzotti added 3 commits February 17, 2026 00:55

Set dev doc links to english language

e4669c0

Introduce logging category for stel.Telescopes

5c76705

SUG: Tentative updates on using ARM64.

0b844c9

gzotti added this to the 26.1 milestone Feb 17, 2026

gzotti self-assigned this Feb 17, 2026

github-actions bot requested review from 10110111 and alex-w February 17, 2026 00:13

10110111 reviewed Feb 17, 2026

View reviewed changes

gzotti added 2 commits February 17, 2026 13:16

fix indentation

dadba9e

Fix scaling of main window

6eb6839

The ARM64 is the first system where I need scaling !=1. On startup the main window is shrinking. This fix prevents the shrinking. If it breaks elsewhere, enclose in WIN32.

gzotti added 5 commits February 22, 2026 23:44

Add a config file to be placed next to stellarium.exe to work with AS…

e22f8b3

…COM.

Improvements for ASCOM telescopes

3f16762

- logging categories - separate debug from warnings - More diagnostics.

Logging categories for more telescopes

2c41ab3

Logging categories for INDI

8342b3e

Add missing header entry

3521b78

Fix for installing stellarium.exe.config

2c15d96

Uh oh!

Comments

Conversation

gzotti commented Feb 17, 2026

Description

Screenshots (if appropriate):

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

10110111 left a comment

Choose a reason for hiding this comment

Uh oh!

10110111 Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

gzotti Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

10110111 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

gzotti Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

10110111 commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gzotti commented Feb 17, 2026

Uh oh!

gzotti commented Feb 18, 2026

Uh oh!

gzotti commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alex-w commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gzotti commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alex-w commented Feb 23, 2026

Uh oh!

alex-w commented Feb 23, 2026

Uh oh!

10110111 commented Feb 23, 2026

Uh oh!

10110111 commented Feb 23, 2026

Uh oh!

gzotti commented Feb 23, 2026

Uh oh!

gzotti commented Feb 23, 2026

Uh oh!

gzotti commented Feb 23, 2026

Uh oh!

gzotti commented Feb 23, 2026

Uh oh!

alex-w commented Feb 23, 2026

Uh oh!

alex-w commented Feb 23, 2026

Uh oh!

alex-w commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

10110111 commented Feb 23, 2026

Uh oh!

gzotti commented Feb 23, 2026

Uh oh!

alex-w commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

10110111 commented Feb 17, 2026 •

edited

Loading

gzotti commented Feb 22, 2026 •

edited

Loading

alex-w commented Feb 22, 2026 •

edited

Loading

gzotti commented Feb 22, 2026 •

edited

Loading

alex-w commented Feb 23, 2026 •

edited

Loading

alex-w commented Feb 23, 2026 •

edited

Loading