refactoring of overload check +semver:none

Author: Stepami

src/Application/HydraScript.Application.StaticAnalysis/Visitors/DeclarationVisitor.cs

@@ -87,11 +87,8 @@ public VisitUnit Visit(FunctionDeclaration visitable)
             parameters,
             visitable.ReturnTypeValue.Accept(_typeBuilder),
             visitable.IsEmpty);
-        if (parentTable.ContainsSymbol(functionSymbolId))
-        {
-            if (!(parentTable.FindSymbol(functionSymbolId)! > functionSymbol))
-                throw new OverloadAlreadyExists(visitable.Name, functionSymbolId);
-        }
+        if (functionSymbolId.Equals(parentTable.FindSymbol(functionSymbolId)?.Id))
+            throw new OverloadAlreadyExists(visitable.Name, functionSymbolId);
 
         for (var i = 0; i < parameters.Count; i++)
         {

tests/HydraScript.IntegrationTests/samples/defaultparams.js

@@ -7,19 +7,21 @@ function g(a:number, b = 0){
 g(1)
 g(1,2)
 
-function f(){
-    >>>"f()"
-}
-function f(a = 0){
-    >>> "f(number)"
-    >>> a
-}
 function f(a = 0, b = 1){
     >>> "f(number, number)"
     >>> a
     >>> b
 }
 
+function f(){
+>>>"f()"
+}
+
+function f(a = 0){
+>>> "f(number)"
+    >>> a
+}
+
 f()
 f(1)
 f(1,2)