#16 - add codegen visitor implementation for 'with' expressions and remove dead code in DotRead

Author: Stepami

src/Application/HydraScript.Application.CodeGeneration/Visitors/ExpressionInstructionProvider.cs

@@ -24,6 +24,7 @@ internal class ExpressionInstructionProvider : VisitorBase<IAbstractSyntaxTreeNo
     IVisitor<UnaryExpression, AddressedInstructions>,
     IVisitor<BinaryExpression, AddressedInstructions>,
     IVisitor<CastAsExpression, AddressedInstructions>,
+    IVisitor<WithExpression, AddressedInstructions>,
     IVisitor<ConditionalExpression, AddressedInstructions>,
     IVisitor<AssignmentExpression, AddressedInstructions>,
     IVisitor<MemberExpression, AddressedInstructions>,
@@ -36,6 +37,8 @@ internal class ExpressionInstructionProvider : VisitorBase<IAbstractSyntaxTreeNo
     public ExpressionInstructionProvider(IValueDtoConverter valueDtoConverter) =>
         _valueDtoConverter = valueDtoConverter;
 
+    public override AddressedInstructions Visit(IAbstractSyntaxTreeNode visitable) => [];
+
     public AddressedInstructions Visit(PrimaryExpression visitable) =>
         [new Simple(_valueDtoConverter.Convert(visitable.ToValueDto()))];
 
@@ -76,9 +79,8 @@ public AddressedInstructions Visit(ObjectLiteral visitable)
 
         var result = new AddressedInstructions { createObject };
 
-        var propInstructions =
-            visitable.Properties.AsValueEnumerable()
-                .SelectMany(property => property.Accept(This));
+        var propInstructions = visitable.AsValueEnumerable()
+            .SelectMany(property => property.Accept(This));
         foreach (var propInstruction in propInstructions)
             result.Add(propInstruction);
 
@@ -158,6 +160,42 @@ public AddressedInstructions Visit(CastAsExpression visitable)
         return result;
     }
 
+    public AddressedInstructions Visit(WithExpression visitable)
+    {
+        if (visitable is { Expression: PrimaryExpression, ComputedCopiedProperties.Count: 0 })
+            return [];
+
+        var objectId = visitable.ObjectLiteral.Id;
+        var createObject = new CreateObject(objectId);
+
+        var result = new AddressedInstructions { createObject };
+
+        var propInstructions = visitable.ObjectLiteral
+            .AsValueEnumerable()
+            .SelectMany(property => property.Accept(This));
+        foreach (var propInstruction in propInstructions)
+            result.Add(propInstruction);
+
+        if (visitable.ComputedCopiedProperties.Count is 0)
+            return result;
+
+        result.AddRange(visitable.Expression is PrimaryExpression ? [] : visitable.Expression.Accept(This));
+
+        var copyFrom = visitable.Expression is PrimaryExpression primary
+            ? (Name)_valueDtoConverter.Convert(primary.ToValueDto())
+            : new Name(result.OfType<Simple>().Last().Left!);
+
+        for (var i = 0; i < visitable.ComputedCopiedProperties.Count; i++)
+        {
+            var property = new Constant(visitable.ComputedCopiedProperties[i]);
+            result.Add(new DotRead(copyFrom, property));
+            var read = result[result.End].Address.Name;
+            result.Add(new DotAssignment(objectId, property, new Name(read)));
+        }
+
+        return result;
+    }
+
     public AddressedInstructions Visit(ConditionalExpression visitable)
     {
         var blockId = $"cond_{visitable.GetHashCode()}";

src/Domain/HydraScript.Domain.BackEnd/Impl/Instructions/WithAssignment/ComplexData/Read/DotRead.cs

@@ -10,8 +10,6 @@ public class DotRead(Name @object, IValue property) : Simple(
 {
     private readonly IValue _property = property;
 
-    public string Property => (string)_property.Get(frame: null)!;
-
     public Simple ToAssignment(IValue value) =>
         new DotAssignment(@object.ToString(), _property, value);