Skip to content

Fix build with statically-linked Python interpreter and bump minimum required version to CMake 3.16 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Fix build with statically-linked Python interpreter and bump minimum required version to CMake 3.16 #325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
116e7df
Fix build with statically-linked Python interpreter
traversaro Apr 9, 2025
07039a3
Bump minimum required version of CMake to 3.16
traversaro Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spatio_temporal_voxel_layer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.5)
cmake_minimum_required(VERSION 3.16)
project(spatio_temporal_voxel_layer)

if(NOT WIN32)
Expand Down Expand Up @@ -79,9 +79,6 @@ rosidl_generate_interfaces(${PROJECT_NAME}
)
rosidl_get_typesupport_target(cpp_typesupport_target "${PROJECT_NAME}" "rosidl_typesupport_cpp")

# Get a linker error when there are undefined symbols
add_link_options(-Wl,--no-undefined)

include_directories(
include
${BOOST_INCLUDE_DIRS}
Expand Down Expand Up @@ -109,6 +106,9 @@ target_link_libraries(${library_name}
OpenVDB::openvdb
)

# Get a linker error when there are undefined symbols
target_link_options(${library_name} PRIVATE -Wl,--no-undefined)

ament_target_dependencies(${library_name} ${dependencies})

if(BUILD_TESTING)
Expand Down