fix: allow editing phase time limits in retro board#803
Open
IJuanI wants to merge 7 commits intoStevenWeathers:mainfrom
Open
fix: allow editing phase time limits in retro board#803IJuanI wants to merge 7 commits intoStevenWeathers:mainfrom
IJuanI wants to merge 7 commits intoStevenWeathers:mainfrom
Conversation
- Add phaseTimeLimitMin field to EditRetro component for editing time limits - Update backend EditRetro function to support phaseTimeLimitMin updates - Update database layer and API interfaces to handle phase time limit editing - Timer now shows when phaseTimeLimitMin > 0 regardless of phaseAutoAdvance setting - Add E2E tests for retro editing with phase time limits - Add API tests for retro creation with timer settings This allows teams to use a timer for time management during brainstorm phase even when they don't want automatic phase transitions.
StevenWeathers
requested changes
Sep 23, 2025
Author
|
Thanks for running the CI! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a missing feature in the retro editing functionality that prevented users from modifying phase time limits after retro creation.
Problem
Missing Edit Functionality: The EditRetro component was missing the
phaseTimeLimitMinfield, so users could only set phase time limits when creating a retro, but not when editing an existing retro.Backend Gap: The backend
EditRetrofunction didn't support updatingphaseTimeLimitMin, making it impossible to change time limits after retro creation.Inconsistent Experience: Users could set independent timer and auto-advance settings during creation, but couldn't modify the timer setting afterward, creating an inconsistent editing experience.
Solution
Frontend Changes
phaseTimeLimitMininput field toEditRetro.sveltecomponentphaseTimeLimitMinto component interface and state managementBackend Changes
EditRetrofunction ininternal/db/retro/retro.goto accept and updatephaseTimeLimitMinparameterphase_time_limit_min = $7to the UPDATE statementinternal/http/retro/events.goto process the new parameterinternal/http/types.goandinternal/http/retro/retro.goKey Benefits
phaseTimeLimitMin > 0regardless ofphaseAutoAdvancesettingUse Cases Now Supported
phaseTimeLimitMin > 0+phaseAutoAdvance = truephaseTimeLimitMin > 0+phaseAutoAdvance = false(now editable)phaseTimeLimitMin = 0(timer hidden regardless of auto-advance setting)Testing Added
E2E Tests (
e2e/tests/retro/retro.spec.ts)phaseTimeLimitMin > 0phaseTimeLimitMin = 0API Tests (
e2e/tests/api/retros.spec.ts)phaseTimeLimitMinandphaseAutoAdvanceparametersFiles Changed
ui/src/components/retro/EditRetro.svelte- Added missing phaseTimeLimitMin fieldui/src/pages/retro/Retro.svelte- Pass phaseTimeLimitMin to EditRetro componentinternal/db/retro/retro.go- Updated EditRetro function signature and SQLinternal/http/retro/events.go- Updated event handler for new parameterinternal/http/types.go- Updated interface definitioninternal/http/retro/retro.go- Updated interface definitione2e/tests/retro/retro.spec.ts- Added E2E testse2e/tests/api/retros.spec.ts- Added API testsBreaking Changes
None - this is a backward-compatible bug fix and enhancement.
Checklist