-
-
Notifications
You must be signed in to change notification settings - Fork 17
Disable ZGC as default garbage collector #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe Dockerfile was updated to modify the Java runtime command used to start the application. Specifically, the JVM option Changes
Poem
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
31-31: Optional: Explicitly specify GC or surface JVM flags
Although G1 is the current default, you may want to pin it via-XX:+UseG1GCto guard against future JDK GC changes. For greater flexibility, consider an entrypoint script that injects additional flags from an environment variable (e.g.JAVA_OPTS).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Execute unit tests (macos-13)
- GitHub Check: Execute unit tests (windows-latest)
- GitHub Check: Execute unit tests (ubuntu-latest)
🔇 Additional comments (1)
Dockerfile (1)
31-31: Approve removal of ZGC flag for broader compatibility
Removing-XX:+UseZGCensures the distroless JRE can run without unmet GC dependencies—modern JDKs default to G1 GC, which is stable and well‑tested.
Summary by CodeRabbit