-
-
Notifications
You must be signed in to change notification settings - Fork 17
Update libwebp to 1.6.0 from 1.5.0 #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe Dockerfile was modified to update the libwebp library from version 1.5.0 to 1.6.0. This involved changing the version argument and updating the corresponding SHA256 checksum to ensure the integrity of the new tarball. No other build or runtime changes were introduced. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Dockerfile (1)
5-9: Consider making the archive name architecture-aware
libwebp-$LIBWEBP_VERSION-linux-x86-64.tar.gzis hard-coded for amd64.
If you plan to build multi-arch images (e.g. arm64 runners on CI or Apple M-series), this will break.A small tweak keeps today’s behaviour while enabling overrides:
-ARG LIBWEBP_FILE="libwebp-$LIBWEBP_VERSION-linux-x86-64.tar.gz" +ARG LIBWEBP_ARCH=${LIBWEBP_ARCH:-linux-x86-64} +ARG LIBWEBP_FILE="libwebp-$LIBWEBP_VERSION-$LIBWEBP_ARCH.tar.gz"Downstream build commands remain unchanged. If multi-arch support is out of scope, feel free to ignore.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Execute unit tests (macos-13)
- GitHub Check: Execute unit tests (windows-latest)
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary by CodeRabbit