Fix sendfile operation on macos #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure `op_ctx` to do a reset at scope exist receives own independent object to call reset on it. I'm not sure of the exact cause but maybe llvm on macos takes a different approach handling lifetime of the object captured when lambda finishes it's scope. Copying the context object to reset lambda capture does the job regardles of lifetime of initial context object.
Member
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
op_ctxtis doing reset at a scope exit receives own independent object to call reset on it.I'm not sure of the exact cause but maybe LLVM on macos takes a different approach handling lifetime of the object captured when lambda finishes it's scope. Copying the context object to reset lambda capture does the job regardless of lifetime of initial context object.