Guard against null content in preparse callback#25
Open
sheldonkotyk wants to merge 2 commits intoStillat:main-v2from
Open
Guard against null content in preparse callback#25sheldonkotyk wants to merge 2 commits intoStillat:main-v2from
sheldonkotyk wants to merge 2 commits intoStillat:main-v2from
Conversation
When Statamic passes null to the preparse callback (e.g. when a tag returns no value on a 404 page), the compile() method throws a TypeError due to its string type hint. Guard against non-string values by returning the content unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Before you get too far, I'd like to see the dependency updates split off into their own PR to keep the descriptions accurate to the changeset. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Statamic passes
nullto the preparse callback — for example, when a tag like{{ seo_pro:meta }}returns no value on a 404 page — theAntlersCompiler::compile()method throws aTypeErrordue to itsstringtype hint:Fix
Added a guard in the
ServiceProviderpreparse callback to return non-string values unchanged, allowing the runtime to handle them as it normally would.Test plan
null(e.g. on 404 pages) no longer throw aTypeError🤖 Generated with Claude Code