Skip to content

Add save to xspec varenergy#963

Merged
matteolucchini1 merged 13 commits intomainfrom
add_save_to_xspec_varenergy
Feb 26, 2026
Merged

Add save to xspec varenergy#963
matteolucchini1 merged 13 commits intomainfrom
add_save_to_xspec_varenergy

Conversation

@matteobachetti
Copy link
Member

This adds the "save to xspec" functionality to variability-energy spectra.

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (7724c74) to head (04a5840).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   96.16%   96.17%           
=======================================
  Files          48       48           
  Lines        9937     9959   +22     
=======================================
+ Hits         9556     9578   +22     
  Misses        381      381           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matteolucchini1
Copy link
Collaborator

Other than the checks not passing, this -mostly- looks good to me.

The only comment I have is that we should be incredibly careful with generating products (like time-averaged spectra) to files as if they were identical to what pipelines produced - we've had this discussion before where we have discrepancies between e.g. what nicerl3 produces, and what we get when we just build energy resolved lightcurves, spectra etc with Stingray going straight from the event files.

My recommendation is to at least raise a warning for users, and to tell them to check that whatever they are building with stingray is consistent with the other mission pipelines.

@matteobachetti
Copy link
Member Author

matteobachetti commented Feb 24, 2026

@matteolucchini1 very good point, I'll extend the existing warning for missing keywords along those lines.

Copy link
Collaborator

@matteolucchini1 matteolucchini1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright LGTM now, just need to get it to pass all the tests :)

@matteobachetti
Copy link
Member Author

@matteolucchini1 it was a temporary glitch due to an issue with the Contribution covenant website. It works now.

@matteolucchini1 matteolucchini1 added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 79b8f9b Feb 26, 2026
18 of 19 checks passed
@matteobachetti matteobachetti deleted the add_save_to_xspec_varenergy branch February 26, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants