playwright - #6025
Merged
Merged
Conversation
stirlingbot
Bot
added
Documentation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Resolve conflicts: - playwright.config.ts: keep PR's richer test-agent config (timeouts, reporter, healer-friendly screenshot/video/trace settings), normalize to double quotes - ConvertE2E.spec.ts: keep PR's real-backend discovery-based tests - conversionEndpointDiscovery.ts: restore helper that main deleted; needed by PR's Convert tests
Reverse the merge resolution for ConvertE2E.spec.ts and drop conversionEndpointDiscovery.ts. Main's PR #6009 intentionally migrated these tests to mock-based (no real backend needed), which is the correct direction — keep that, keep only playwright.config.ts from PR's side (richer test-agent/healer config).
auth-login.spec.ts:140 — session expiry redirect:
The test used waitForURL('**/') which only matches URLs ending in '/'
and failed on /merge. Loosen to accept any non-/login URL since the app
may restore the original page or land on the dashboard post-login.
e2e-pdf-operations.spec.ts — merge 2/3 file tests:
The Merge tool lands in 'viewer' mode after upload and requires a
manual switch to file editor before the run button enables. The UI
surfaces a 'Go to file editor' button for this — click it first in
the shared executeAndWaitForResults helper when visible.
On firefox and webkit, the tour tooltip ("Watch walkthroughs here…")
intercepts pointer events on the convert button, causing click timeouts.
Add a dismissTourTooltip helper invoked before the click. Chromium
auto-handles it, but the explicit dismiss is a no-op there so tests
remain green on all three browsers.
On webkit, clicking the breadcrumb a[href="/"] did not trigger React Router navigation — the URL stayed on /merge (or /compress). The sidebar "Tools" link consistently navigates on all three browsers. Switch both browser-navigation.spec.ts and tool-pages-common.spec.ts to target the sidebar link by its accessible role+name.
Contributor
Frontend Check FailedThere are issues with your frontend code that will need to be fixed before they can be merged in. Run |
Frooodle
marked this pull request as ready for review
April 23, 2026 20:29
Frooodle
requested review from
ConnorYoh,
EthanHealy01,
Ludy87,
jbrunton96 and
reecebrowne
as code owners
April 23, 2026 20:29
dosubot
Bot
added
the
size:L
stirlingbot
Bot
added
Docker
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
dosubot
Bot
added
size:XL
Contributor
✅ Backend License Check PassedAll backend dependencies have valid and allowed licenses. The backend license report has been updated successfully. |
reecebrowne
approved these changes
Apr 27, 2026
jbrunton96
approved these changes
Apr 27, 2026
ConnorYoh
approved these changes
Apr 27, 2026
jbrunton96
reviewed
Apr 27, 2026
Comment on lines
+15
to
+16
| * npx playwright test --project=stubbed | ||
| * npx playwright test --project=live |
Contributor
There was a problem hiding this comment.
Do these need Task rules?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)