-
Notifications
You must be signed in to change notification settings - Fork 2
build(deps): Bump autumn-cli 1.1.0 → 1.2.0, winow 0.9.4 → 0.11.0 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDependency versions in packagedef were updated (winow 0.9.4→0.11.0, autumn-cli 1.1.0→1.2.0). A byte order mark (BOM) appears before the first identifier. No other changes to exported/public entities. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packagedef(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: test (stable) / build (windows-latest, stable)
- GitHub Check: test (dev) / build (ubuntu-latest, dev)
- GitHub Check: test (stable) / build (ubuntu-latest, stable)
- GitHub Check: test (dev) / build (ubuntu-latest, dev)
- GitHub Check: sonar / test
- GitHub Check: test (stable) / build (ubuntu-latest, stable)
| @@ -1,4 +1,4 @@ | |||
| Описание.Имя("httpbin") | |||
| Описание.Имя("httpbin") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Unintended BOM character detected.
A UTF-8 Byte Order Mark (U+FEFF) appears before Описание.Имя("httpbin"). BOMs can cause parsing errors in some interpreters and are generally unnecessary in UTF-8 files.
Verify whether the oscript interpreter tolerates BOMs in packagedef files:
🏁 Script executed:
#!/bin/bash
# Check if other packagedef files in the repository contain BOMs
fd -e packagedef -x file {} \; | grep -i "bom"
# Check the actual byte sequence at the start of the file
head -c 10 packagedef | od -A x -t x1z -vLength of output: 40
🏁 Script executed:
#!/bin/bash
# Verify BOM presence in 'packagedef' and any other files named 'packagedef' using Python
python3 - << 'EOF'
import glob, os
def has_bom(path):
with open(path, 'rb') as f:
return f.read(3) == b'\xef\xbb\xbf'
# Check main file
main = 'packagedef'
print(f"{main}: BOM present: {has_bom(main)}")
# Check other files named 'packagedef'
for f in glob.glob('**/packagedef', recursive=True):
if os.path.abspath(f) != os.path.abspath(main):
print(f"{f}: BOM present: {has_bom(f)}")
EOFLength of output: 175
🏁 Script executed:
#!/bin/bash
# Verify BOM presence in 'packagedef' and any other files named 'packagedef' using Python
python3 - << 'EOF'
import glob, os
def has_bom(path):
with open(path, 'rb') as f:
return f.read(3) == b'\xef\xbb\xbf'
files = glob.glob('**/packagedef', recursive=True) + ['packagedef']
checked = set()
for path in files:
real = os.path.abspath(path)
if real in checked or not os.path.isfile(path):
continue
checked.add(real)
print(f"{path}: BOM present: {has_bom(path)}")
EOFLength of output: 29
Remove UTF-8 BOM from packagedef
A UTF-8 Byte Order Mark was detected at the start of packagedef. BOMs can cause parsing errors in the oscript interpreter. Remove the leading BOM so the file begins directly with Описание.Имя("httpbin").
🤖 Prompt for AI Agents
In packagedef around lines 1 to 1, the file contains a UTF-8 Byte Order Mark
(BOM) at the very start which can break the oscript interpreter; remove the BOM
so the file begins directly with Описание.Имя("httpbin") by re-saving the file
without BOM (e.g., choose UTF-8 without BOM or strip the leading 0xEF,0xBB,0xBF
bytes) and verify the first byte is the 'О' character.
| .ЗависитОт("winow", "0.11.0") | ||
| .ЗависитОт("autumn-cli", "1.2.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify dependency versions exist and check for breaking changes.
The dependency updates look reasonable, but ensure the specified versions exist and are compatible with this package.
Run the following script to verify the versions and check for any compatibility issues:
🏁 Script executed:
#!/bin/bash
# Check if the specified versions exist in the repositories
echo "Checking winow 0.11.0..."
curl -s "https://hub.oscript.io/api/v1/packages/winow" | jq '.versions[] | select(.version == "0.11.0")'
echo "Checking autumn-cli 1.2.0..."
curl -s "https://hub.oscript.io/api/v1/packages/autumn-cli" | jq '.versions[] | select(.version == "1.2.0")'
# Check GitHub releases
echo "Checking winow releases..."
gh api repos/oscript-library/winow/releases --jq '.[] | select(.tag_name | contains("0.11.0")) | {tag_name, published_at, body}'
echo "Checking autumn-cli releases..."
gh api repos/oscript-library/autumn-cli/releases --jq '.[] | select(.tag_name | contains("1.2.0")) | {tag_name, published_at, body}'Length of output: 226
🏁 Script executed:
#!/bin/bash
echo "winow tags:"
curl -s https://api.github.com/repos/oscript-library/winow/tags | jq '.[].name' | grep -E 'v?0\.11\.0'
echo "autumn-cli tags:"
curl -s https://api.github.com/repos/oscript-library/autumn-cli/tags | jq '.[].name' | grep -E 'v?1\.2\.0'
echo "winow release v0.11.0 details:"
curl -s https://api.github.com/repos/oscript-library/winow/releases | jq '.[] | select(.tag_name == "v0.11.0" or .tag_name == "0.11.0") | {tag_name, published_at, body}'
echo "autumn-cli release v1.2.0 details:"
curl -s https://api.github.com/repos/oscript-library/autumn-cli/releases | jq '.[] | select(.tag_name == "v1.2.0" or .tag_name == "1.2.0") | {tag_name, published_at, body}'Length of output: 94
packagedef: missing release tags for [email protected] and [email protected]
Neither version exists in their GitHub repositories; ensure these releases are published or update to valid published versions.
🤖 Prompt for AI Agents
In packagedef around lines 14 to 15, the dependency entries reference
non-existent release tags ([email protected] and [email protected]); either publish
those exact tags in the respective GitHub repos or update these lines to point
to valid, published release versions (or alternate semver ranges) that exist in
each repo, then re-run dependency validation to ensure the package build
resolves successfully.
|
Добавлена поддержка через PR #10 |
(repo · hub)
(repo · hub)
Summary by CodeRabbit