Skip to content

chore: Split Registry#1070

Draft
Stranger6667 wants to merge 6 commits intomasterfrom
registry-index-resolver-split
Draft

chore: Split Registry#1070
Stranger6667 wants to merge 6 commits intomasterfrom
registry-index-resolver-split

Conversation

@Stranger6667
Copy link
Copy Markdown
Owner

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 10, 2026

Merging this PR will degrade performance by 33.47%

⚡ 7 improved benchmarks
❌ 8 regressed benchmarks
✅ 53 untouched benchmarks
🆕 10 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
build[CITM] 366 µs 322.5 µs +13.49%
build[Recursive] 2 ms 1.8 ms +10.26%
build[GeoJSON] 1,069.8 µs 886.5 µs +20.68%
build[Swagger] 5.7 ms 5.1 ms +10.97%
build[Open API] 5 ms 4.5 ms +10.83%
build[FHIR] 177.6 ms 142.6 ms +24.61%
🆕 prepare_owned[draft 2020-12] N/A 40.2 µs N/A
try_new[draft 7] 33.2 µs 37.8 µs -12.23%
🆕 prepare_owned[draft 2019-09] N/A 39.9 µs N/A
try_with_resource[Open API] 334.4 µs 236.6 µs +41.31%
🆕 prepare_owned[draft 4] N/A 37.5 µs N/A
try_with_resource[CITM] 45.2 µs 53.9 µs -16.08%
🆕 prepare_owned_with_specifications[Open API] N/A 348.1 µs N/A
🆕 prepare_owned[draft 6] N/A 38.4 µs N/A
🆕 prepare_owned_with_specifications[CITM] N/A 54.7 µs N/A
resolve[small] 2.6 µs 3 µs -12.59%
🆕 prepare_owned[draft 7] N/A 39.7 µs N/A
🆕 prepare_owned_with_specifications[Fast] N/A 41.2 µs N/A
🆕 prepare_owned_with_specifications[Swagger] N/A 467.3 µs N/A
🆕 prepare_owned_with_specifications[GeoJSON] N/A 76.8 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.


Comparing registry-index-resolver-split (b1f418c) with master (fb45aed)

Open in CodSpeed

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 93.56789% with 117 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.06%. Comparing base (fb45aed) to head (f2dcfd5).

Files with missing lines Patch % Lines
crates/jsonschema-referencing/src/registry.rs 92.74% 58 Missing ⚠️
crates/jsonschema/src/options.rs 88.52% 14 Missing ⚠️
crates/jsonschema-cli/src/main.rs 65.71% 12 Missing ⚠️
crates/jsonschema/src/bundler.rs 69.69% 10 Missing ⚠️
crates/jsonschema-referencing/src/index.rs 94.96% 7 Missing ⚠️
...jsonschema-referencing/src/specification/draft4.rs 94.44% 4 Missing ⚠️
...chema-referencing/src/specification/draft201909.rs 96.05% 3 Missing ⚠️
...jsonschema-referencing/src/specification/draft6.rs 95.00% 3 Missing ⚠️
...jsonschema-referencing/src/specification/draft7.rs 95.52% 3 Missing ⚠️
...hema-referencing/src/specification/subresources.rs 96.15% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1070      +/-   ##
==========================================
- Coverage   94.50%   94.06%   -0.44%     
==========================================
  Files          81       81              
  Lines       22610    23601     +991     
==========================================
+ Hits        21367    22201     +834     
- Misses       1243     1400     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Stranger6667 Stranger6667 force-pushed the registry-index-resolver-split branch 28 times, most recently from e235a52 to 470fb81 Compare March 16, 2026 18:17
@Stranger6667 Stranger6667 force-pushed the registry-index-resolver-split branch 4 times, most recently from 969c63b to 2304574 Compare March 17, 2026 16:41
@Stranger6667 Stranger6667 force-pushed the registry-index-resolver-split branch 2 times, most recently from f2dcfd5 to e8bb8f1 Compare April 6, 2026 14:39
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
Signed-off-by: Dmitry Dygalo <dmitry@dygalo.dev>
@Stranger6667 Stranger6667 force-pushed the registry-index-resolver-split branch from e8bb8f1 to b1f418c Compare April 6, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant