Skip to content

Conversation

@Stranger6667
Copy link
Owner

Resolves #851

@Stranger6667 Stranger6667 marked this pull request as draft November 19, 2025 00:12
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 93.63426% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.73%. Comparing base (4b932ca) to head (08273be).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema-referencing/src/registry.rs 91.36% 29 Missing ⚠️
crates/jsonschema-referencing/src/builder.rs 93.04% 13 Missing ⚠️
crates/jsonschema-referencing/src/resource.rs 68.75% 10 Missing ⚠️
crates/jsonschema/src/compiler.rs 96.96% 2 Missing ⚠️
crates/jsonschema-referencing/src/context.rs 98.98% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
- Coverage   94.10%   93.73%   -0.38%     
==========================================
  Files          78       80       +2     
  Lines       16465    16677     +212     
==========================================
+ Hits        15495    15632     +137     
- Misses        970     1045      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #883 will degrade performances by 91.24%

Comparing dd/rework-registry (08273be) with master (8596a17)

Summary

⚡ 2 improvements
❌ 20 regressions
✅ 39 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
resolve[small] 2.7 µs 8.4 µs -68.31%
pointer[double] 5.7 µs 11.5 µs -50.3%
pointer[long] 12.9 µs 19.5 µs -34.03%
pointer[single] 4.6 µs 10.4 µs -55.9%
try_new[draft 2019-09] 26.3 µs 268.8 µs -90.22%
try_new[draft 2020-12] 27 µs 270.5 µs -90.02%
try_new[draft 4] 25.2 µs 267.7 µs -90.57%
try_new[draft 6] 26.2 µs 271.8 µs -90.36%
try_new[draft 7] 28 µs 269.5 µs -89.62%
try_with_resource[CITM] 35.7 µs 278.8 µs -87.2%
try_with_resource[Fast] 23.2 µs 265.2 µs -91.24%
try_with_resource[GeoJSON] 62.6 µs 299.6 µs -79.1%
try_with_resource[Open API] 220.4 µs 433.7 µs -49.18%
try_with_resource[Swagger] 268.5 µs 454.2 µs -40.89%
build[CITM] 417.6 µs 744.8 µs -43.93%
build[FHIR] 208.4 ms 182.7 ms +14.08%
build[Fast] 174.5 µs 536.2 µs -67.46%
build[GeoJSON] 1.3 ms 1.5 ms -15.99%
evaluate[CITM/Catalog] 96.8 ms 84 ms +15.16%
is_valid[Fast/Invalid] 741.1 ns 857.8 ns -13.6%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Stranger6667 Stranger6667 force-pushed the dd/rework-registry branch 2 times, most recently from be87c37 to 6f95625 Compare November 19, 2025 10:56
Signed-off-by: Dmitry Dygalo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential unsoundness in referencing

2 participants