Skip to content

Conversation

@Stranger6667
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 96.71053% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.15%. Comparing base (b4ec427) to head (db350e3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema-referencing/src/registry.rs 96.07% 4 Missing ⚠️
crates/jsonschema/src/keywords/ref_.rs 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   94.13%   94.15%   +0.01%     
==========================================
  Files          78       78              
  Lines       16590    16719     +129     
==========================================
+ Hits        15617    15741     +124     
- Misses        973      978       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 30, 2025

CodSpeed Performance Report

Merging #896 will degrade performances by 31.17%

Comparing dd/fix-more-refs (db350e3) with master (b4ec427)

Summary

❌ 10 regressions
✅ 51 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
try_new[draft 2019-09] 26.1 µs 30.3 µs -14.09%
try_new[draft 2020-12] 26.7 µs 30.9 µs -13.69%
try_new[draft 4] 24.9 µs 28.8 µs -13.53%
try_new[draft 6] 25.9 µs 29.9 µs -13.37%
try_new[draft 7] 27.7 µs 31.8 µs -12.82%
try_with_resource[CITM] 35.6 µs 43.1 µs -17.41%
try_with_resource[Fast] 21.8 µs 26.4 µs -17.35%
try_with_resource[GeoJSON] 61.6 µs 75.2 µs -18.11%
try_with_resource[Open API] 218.8 µs 317.9 µs -31.17%
try_with_resource[Swagger] 267.3 µs 369.8 µs -27.72%

@Stranger6667 Stranger6667 marked this pull request as ready for review November 30, 2025 14:03
@Stranger6667 Stranger6667 merged commit 177e0b0 into master Nov 30, 2025
48 of 49 checks passed
@Stranger6667 Stranger6667 deleted the dd/fix-more-refs branch November 30, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants