Feature/migrate to real data#106
Closed
james-cross wants to merge 6 commits intoStreetSupport:stagingfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the migration from local JSON mocks to fully dynamic, database-driven data for the Find Help flow and Organisation entry pages. It also includes aligned unit tests, updated E2E tests, and resolves all type/lint issues related to the new normalised data shape.
Included in this PR
Find Help:
Switched from static service-providers.json to live API routes.
Uses real database categories, client groups, services, and location-aware results.
Updated search logic to correctly order, filter, and group services.
Organisation Pages:
Implemented dynamic [slug] route fetching real organisation data, addresses, and provided services.
Added proper normalisation: all keys are consistently lowercased (name, addresses, etc.).
Built OrganisationShell with modular subcomponents: Overview, Locations, ServicesAccordion, ContactBlock, Footer.
Connected real grouped services, addresses with maps, and social share links.
Testing:
Updated unit tests to mock realistic API responses.
Fixed component tests for OrganisationOverview, OrganisationLocations, OrganisationServicesAccordion, and ContactBlock.
Refreshed Playwright E2E tests to verify real org pages, map rendering, accordion toggle, and share/disclaimer behaviour.
All tests pass and linting is clean.
Notes
The API shape is now finalised for both Find Help and Organisation details.
This ensures future styling and features are built on real, production-like data.
Minor tweaks may be required when plugging in final location coordinates or address formats.