Skip to content

Dev: Addon install action exceptions #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kKaskak merged 3 commits into from
Jan 22, 2026
+13 −1
Merged

Dev: Addon install action exceptions #1091

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d2744
feat(Addon): add addon shows toast if url is not valid
elpiel Dec 15, 2025
673c22a
chore: bump core-web to feature branch
elpiel Dec 15, 2025
a5265ba
Merge branch 'development' into feat/dispatching-addon-install-action…
kKaskak Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/routes/Addons/Addons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const { default: Icon } = require('@stremio/stremio-icons/react');
const { usePlatform, useBinaryState, withCoreSuspender } = require('stremio/common');
const { AddonDetailsModal, Button, Image, MainNavBars, ModalDialog, SearchBar, SharePrompt, TextInput, MultiselectMenu } = require('stremio/components');
const { useServices } = require('stremio/services');
const useToast = require('stremio/common/Toast/useToast');
const Addon = require('./Addon');
const useInstalledAddons = require('./useInstalledAddons');
const useRemoteAddons = require('./useRemoteAddons');
Expand All @@ -20,6 +21,7 @@ const Addons = ({ urlParams, queryParams }) => {
const { t } = useTranslation();
const platform = usePlatform();
const { core } = useServices();
const toast = useToast();
const installedAddons = useInstalledAddons(urlParams);
const remoteAddons = useRemoteAddons(urlParams);
const [addonDetailsTransportUrl, setAddonDetailsTransportUrl] = useAddonDetailsTransportUrl(urlParams, queryParams);
Expand All @@ -29,7 +31,17 @@ const Addons = ({ urlParams, queryParams }) => {
const addAddonUrlInputRef = React.useRef(null);
const addAddonOnSubmit = React.useCallback(() => {
if (addAddonUrlInputRef.current !== null) {
setAddonDetailsTransportUrl(addAddonUrlInputRef.current.value);
try {
let url = new URL(addAddonUrlInputRef.current.value).toString();
setAddonDetailsTransportUrl(url);
} catch (e) {
toast.show({
type: 'error',
title: `Failed to parse addon url: ${addAddonUrlInputRef.current.value}`,
timeout: 10000
});
console.error('Failed to parse addon url:', e);
}
}
}, [setAddonDetailsTransportUrl]);
const addAddonModalButtons = React.useMemo(() => {
Expand Down