Skip to content

Conversation

@GaryGosh
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2024

CLA assistant check
All committers have signed the CLA.

@tymmesyde
Copy link
Member

Hi! Thank you for your PR, can you sign the CLA?
For this to work well it needs some kind of memory logic
For example let's say that you selected the third english subtitle, if you hide the subtitles and show them again, it will select the first subtitles in the list but it should use the same that was previously selected

@GaryGosh
Copy link
Contributor Author

thank you very much for your feedback . sure I will add that

@GaryGosh
Copy link
Contributor Author

@tymmesyde have updated my pr . pls review

@GaryGosh
Copy link
Contributor Author

Can you check this pls @tymmesyde

@kKaskak
Copy link
Member

kKaskak commented Jan 5, 2025

Hey pls resolve the conflicts in your PR. Thank you

@kKaskak kKaskak added the enhancement Current feature enhancement label Jan 5, 2025
@GaryGosh
Copy link
Contributor Author

@kKaskak I have resolved the conflicts , Thank you!

@kKaskak kKaskak requested a review from tymmesyde January 14, 2025 15:28
@kKaskak
Copy link
Member

kKaskak commented Jan 21, 2025

Hey, looking at it now it would be good to add it to the settings shortcuts section with the proper translation

@GaryGosh
Copy link
Contributor Author

Sure I will include within this pr itself , thank you !

@kKaskak kKaskak added feature New feature implementation and removed enhancement Current feature enhancement labels Apr 25, 2025
@kKaskak kKaskak changed the title added shortkey to toggle caption. UX improvement. Player: Implement shortkey to toggle caption Oct 7, 2025
@kKaskak kKaskak modified the milestone: v5.0.0-beta.28 Oct 7, 2025
@kKaskak
Copy link
Member

kKaskak commented Oct 8, 2025

gm did you consider making the changes i requested to add it to settings as well?

@kKaskak kKaskak linked an issue Oct 9, 2025 that may be closed by this pull request
@GaryGosh
Copy link
Contributor Author

@kKaskak sorry for the delay. met with an accident. I have made the changes pls review

@GaryGosh
Copy link
Contributor Author

can you review this pr @tymmesyde

@kKaskak kKaskak added this to the v5.0.0-beta.30 milestone Jan 22, 2026
kKaskak
kKaskak previously approved these changes Jan 22, 2026
@kKaskak kKaskak removed their assignment Jan 22, 2026
@kKaskak kKaskak self-requested a review January 22, 2026 13:22
@kKaskak kKaskak merged commit 9503e90 into Stremio:development Jan 22, 2026
2 checks passed
@tymmesyde tymmesyde changed the title Player: Implement shortkey to toggle caption Player: Add shortcut to toggle subtitles Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Ability to toggle subtitles with shortcut

4 participants