Added and updated icons to new FreeCAD guidelines

[maxwxyz]

Added and updated icons to new FreeCAD guidelines.

Before:

After

@Stu142

[Stu142]

Thank you for your contribution. I like the sleeker look, but I do have a couple of thoughts.

I am not aware of the guidelines, as I didn't make the current icons. I feel it is quite a bit harder to determine if each tool is active or not without having much color. Tools such as the change layout and place label shelf depend on user selection, and I think it would be useful if they jump out at you a bit more when active and are possible to use.

Second, it is a bit harder to differentiate between the blank bin, the simple storage bin, and the parts bin at the Default size of 24 px.

Update, Ignore this one: Lastly, I think the custom bin and baseplate could use some kind of icon such as a gear to indicate the custom nature of it. This one is more of a minor improvement, as I think they would also be good as they are.

Let me know what you think or if there are reasons for these decisions that I am unaware of.

[greg19]

These look nice!

Are you talking about those guideliness? These icons doesn't seem to follow the rules. Is there something newer?

I also liked the view aimed from above more. This direction makes it harder for me to see what's in the picture (especially the baseplates).

I feel it is quite a bit harder to determine if each tool is active or not without having much color.

Agreed. I had a quick look at other workbenches' icons and they all use colors.

Second, it is a bit harder to differentiate between the blank bin, the simple storage bin, and the parts bin at the Default size of 24 px.

What's the deal with the pixel count? It's a SVG, it has no dimensions. Though I agree that the contrast/color could be better.

Lastly, I think the custom bin and baseplate could use some kind of icon such as a gear to indicate the custom nature of it. This one is more of a minor improvement, as I think they would also be good as they are.

I think the proposed one is good, the shape is clearly non-rectangular. A gear would suggest some kind of settings to me. I don't think the custom shape is non-standard enough to have some kine of differentiator (or at least I would like it to be polished enough in the future to not need it – maybe even become the default way of creating bins).

[Stu142]

I also liked the view aimed from above more. This direction makes it harder for me to see what's in the picture (especially the baseplates).

agreed. It kind of works for the bins as the bottom profile is clear and I think that looks nice but hard to tell the difference between them.

What's the deal with the pixel count? It's a SVG, it has no dimensions. Though I agree that the contrast/color could be better.

I was just referring to the size of the icon displayed in the tool bar. You can change it in general settings size of toolbar icons the default is 24 px. If you increase the size they are much clearer but most people probably run default as they take up a lot of space.

I think the proposed one is good, the shape is clearly non-rectangular. A gear would suggest some kind of settings to me. I don't think the custom shape is non-standard enough to have some kine of differentiator (or at least I would like it to be polished enough in the future to not need it – maybe even become the default way of creating bins).

good point I will remove that one.

[Stu142]

I do think the icons for the custom bin and baseplate, change shape, and label shelf are much better than the text we have now, so I would be interested in replacing those right away in a separate PR, or I can make that change here.

[maxwxyz]

Sure.
The icons were don based on the draft of the overhauled icon styleguide @obelisk79 is working on. I might find time on the weekend to redo the changes, maybe the baseplates in 2D from above to be able to actually identify them.

[greg19]

Do you have a reference for the new icon styleguide?

[obelisk79]

Do you have a reference for the new icon styleguide?

The draft guidelines are still in private development. I was working on them in the open for a while and got a lot of great input initially and then it started to die in the weeds of endless opinions on trivial details. So it is currently in a restricted repo on github until I've managed to develop a larger body of icons and resolve obvious issues with the guidelines before bringing them back out into the open for community review and comment.

[maxwxyz]

we can also hold this PR

[johnny-bit]

I did #3 and I do like the new icons. I haven't had the time to play with new features so I haven't made "old-style" icons for the new features.

One thing that bothers me about the new icons is the contrast: it's VERY hard to differentiate different bin types that are next to each other with the exception of the leaf being more visible on eco bin in new version.

[maxwxyz]

Guidelines will probably be adjusted and new icons along with a token theme system is planned for FreeCAD 1.2
We can hold the PR or merge as is or just close it, as you like.