Skip to content

Remove legacy LBin #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greg19 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove legacy LBin #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions freecad/gridfinity_workbench/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,50 +475,6 @@ def generate_gridfinity_shape(self, obj: fc.DocumentObject) -> Part.Shape:
return fuse_total


class LBinBlank(FoundationGridfinity):
"""Legacy L shaped bin.

This class is never created in the current version, but might be used in old files.

When opening a file that uses this class, the objects will be migrated to
use the CustomBlankBin class. This needs to happen only once per file.

This class should removed from the project after 01.08.2025, when the
migration perioid ends. It is the only thing that needs action at that time.
"""

def __init__(self, _obj: fc.DocumentObject) -> None:
raise AssertionError(
"New LBinBlank objects should not be created. Use CustomBlankBin instead.",
)

def onDocumentRestored(self, obj: fc.DocumentObject) -> None: # noqa: N802
# save the layout to pass to CustomBlankBin, with some padding
layout = [[False] * (obj.y1GridUnits + 6) for _ in range(obj.x1GridUnits + 6)]
for x in range(obj.x1GridUnits):
for y in range(obj.y1GridUnits):
if x < obj.x2GridUnits or y < obj.y2GridUnits:
layout[x + 3][y + 3] = True

tmp = utils.new_object("tmp")
properties = set(obj.PropertiesList) - set(tmp.PropertiesList)
tmp.Document.removeObject(tmp.Name)

property_values = [(p, getattr(obj, p)) for p in properties]
for p in properties:
obj.removeProperty(p)

CustomBlankBin(obj, layout)

for p, value in property_values:
if hasattr(obj, p):
setattr(obj, p, value)

fc.Console.PrintMessage(
f"Your '{obj.Label}' L-shaped bin has been migrated to the Custom bin",
)


class CustomBlankBin(FoundationGridfinity):
"""Gridfinity CustomBlankBin object."""

Expand Down