Feature: Support Thin-style Stacking Lips #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the positioning of the scoop when the stacking lip is disabled, ensuring it aligns flush with the bin walls. Because the scoop is now flush with the bin wall, we also need to trim the scoop to prevent it from extending beyond the rounded corners of the bin when no stacking lip is present.
The thin stacking lip style modifies the bottom section of the stacking lip profile to create a more streamlined appearance, while reducing the ability to stack bins securely compared to the standard stacking lip. This option can be toggled on or off via a new property in the Gridfinity feature settings.
Reduce the width of the shelf and adjust the scoop position when the thin stacking lip style is selected, ensuring consistent alignment.
…unction. Consolidate the calculation of the stacking lip offset into a dedicated `_stacking_lip_offset()` helper function (adjacent to the `_stacking_lip_profile()` function). This function computes the width of the stacking lip relative to the inside wall. This is used in `make_label_shelf()` and `make_scoop()` to ensure consistent calculations and improve code readability.
Author
|
Oh, and I'd like to express my thanks and admiration for the work to provide this exceedingly useful addon for freecad. To illustrate the impacts of the proposed changes.... The original "thick-lipped" stacking lip style vs the new "thin-lipped" style: 
Showing the new location of the scoop when the stacking lip is disabled: 
The new scoop positions for the "thick-lipped" style and the new "thin-lipped" style: 
|
This was referenced Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a thin stacking lip style (eg. see the thin lip style at https://gridfinitygenerator.com).
The thin stacking lip style modifies the bottom section of the stacking lip profile to create a more streamlined appearance and feel, while reducing the ability to stack bins securely compared to the standard stacking lip. I find the thin lip style more useful and aesthetically pleasing for simple desk drawer oranisers.
This option can be toggled on or off via a new property (
StackingLipThinStyle) in the Gridfinity feature settings. The option is disabled by default.This PR consists of 4 separate commits:
I have not created any automated tests for this PR, but I have extensively tested and printed test objects with various combinations with scoops and shelves enabled/disabled and the various lip styles (off, thin, full).
I am happy to squash or reorganise these commits to suit the needs of the project.
Closes #114
Closes #101
Closes #70