Open
Conversation
In PHP 8.5, non-canonical scalar type casts (boolean|double|integer|binary) deprecated. See https://php.watch/versions/8.5/boolean-double-integer-binary-casts-deprecated.
escopecz
approved these changes
Jan 12, 2026
escopecz
left a comment
escopecz
left a comment
There was a problem hiding this comment.
We are also getting the deprecation. This is the suggested solution:
vendor/studio-42/elfinder/php/elFinder.class.php:4392
Non-canonical cast (double) is deprecated, use the (float) cast instead
7 tasks
|
@troex do you think this could be merged and released? It's blocking support for PHP 8.5 for Mautic. All other dependencies are supporting PHP 8.5 now. |
|
Oh man, it would be ridiculous to fork this Composer Package just because of this one line change, wouldn't it? |
escopecz
added a commit
to escopecz/mautic
that referenced
this pull request
Mar 17, 2026
… the maintainers of elFinder catch up
mautibot
pushed a commit
to mautic/core-lib
that referenced
this pull request
Mar 19, 2026
… the maintainers of elFinder catch up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PHP 8.5, non-canonical scalar type casts (boolean|double|integer|binary) deprecated.
See https://php.watch/versions/8.5/boolean-double-integer-binary-casts-deprecated.