-
Notifications
You must be signed in to change notification settings - Fork 23
Update Kafka version to 4.0 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
Hey Jakub, and thanks! Just got back from KubeCon with a hefty backlog 😅 Reviewing this is on my TODO list! |
|
No worries, it is not urgent. The current code works with Kafka 4.0. I just wanted to keep it a bit up to date. |
anderseknert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just some questions but nothing blocking.
| - "--set=bundles.authz.resource=bundle.tar.gz" | ||
| depends_on: | ||
| - nginx | ||
| zookeeper: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
README.md
Outdated
|
|
||
| ### Prerequisites | ||
|
|
||
| * Kafka 2.7.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? i.e. you can still drop this jar into a Kafka that old?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The code itself is not really changed much. But the changes around Jackson dependencies make it compatible with Kafka 3.8 and newer (because of the Jackson versions it uses). I guess that should be fine as there are no real new feature here and users of older Kafka versions can use the previous release of the OPA Authorizer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fine with me 👍
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
Changes LGTM, feel free to merge whenever you want. |
Kafka has recently had a new major release 4.0. This PR updates the OPA Authorizer to use Kafka 4.0 as well: