Merged
Conversation
added 2 commits
January 10, 2025 13:40
This is not ideal, but the heuristic works remarkably well.
Contributor
|
This, much needed and welcomed |
michaelblyons
force-pushed
the
aws/acl
branch
from
71122b4 to
186ce08
Compare
michaelblyons
commented
Feb 17, 2025
deathaxe
reviewed
Apr 26, 2025
Co-authored-by: deathaxe <16542113+deathaxe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs tests, but I'm curious what users think about these special-case heuristics. I've found them to be helpful.