Skip to content

Fix: resolve overlapping tab nodes #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: resolve overlapping tab nodes #566

wants to merge 1 commit into from

Conversation

@NeisesMike
Copy link
Contributor

@NeisesMike NeisesMike commented Nov 26, 2024

Changes made in this pull request

  • Fix an issue where crafting nodes sometimes overlap. If there are multiple tab nodes under the same node, and one of those tab nodes is expanded, the other tab nodes remain visible. This can cause nodes to be inaccessible. The resolution is a simple postfix patch over the uGUI_CraftingMenu.Expand method. See the images below for a before/after.

Breaking changes

  • N/A

20241125235929_1
20241126000101_1
20241125235934_1

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@NeisesMike
Copy link
Contributor Author

NeisesMike commented Nov 26, 2024

I have read the CLA Document and I hereby sign the CLA

@NeisesMike
Copy link
Contributor Author

NeisesMike commented Nov 26, 2024

recheck

github-actions bot added a commit that referenced this pull request Nov 26, 2024
@github-actions
@NeisesMike has signed the CLA in #566
4e09134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NeisesMike