Add bates number params to AL Document

[BryceStevenWilley]

Lets the ALDocumentBundle use bates_number function when generating a PDF, as well as the work-in-progress params.

Depends on jhpyle/docassemble#898

[nonprofittechy]

LGTM!

[nonprofittechy]

@BryceStevenWilley let me know when this is really ready to review/merge--looks like you still made recent changes

[BryceStevenWilley]

I had been waiting for jhpyle/docassemble#898 to be merged, but missed that it just got cherry-picked and is already in 1.9.2. Needs some testing there, but it shouldn't have to change much.

[nonprofittechy]

Changing to draft--update state when it's ready to merge, and we can do a major version bump if we need if this depends on a specific Docassemble release

[BryceStevenWilley]

Okay, finished testing again, there were some bug fixes that didn't make it into Docassemble that I made another PR for at jhpyle/docassemble#914, but whether that's in doesn't affect this PR (bates_number() will just be broken for normal docassemble users until that's merged).

It does still require docassemble 1.9.2, so it might be worth the major version bump.

[BryceStevenWilley]

Additional discovery; ALExhibitDocument will error in Docassemble 1.9.2, as it partially uses the bates numbering stuff. We're only on 1.9.1 for our prod server, so I'm going to add a fix for ALExhibitDocument (working on it right now) to this PR, and then we'll have to merge / upgrade when we upgrade to 1.9.2.

[BryceStevenWilley]

Switching back to draft, since I realized that this will break all existing interviews that don't start from the beginning.

[BryceStevenWilley]

Forgot to comment back here, but fixed the remaining issues that I had found with the ALDocument (mainly being able to run with previously created objects. Should be ready for a re-review.

[ekressmiller]

Thanks so much for working on this! We're hoping to go live with the divorce tool that uses this change next week or the following week if possible.

[BryceStevenWilley]

It does still require docassemble 1.9.2, so it might be worth the major version bump.

Realized that even though this does use docassemble 1.9.2 features / kwargs, it just silently drops the extra ones not used in lower versions of docassemble and doesn't error (tested this fact locally on 1.9.1). So I think is safe to merge / release without any version bumps in the AssemblyLine package.

@nonprofittechy, tagging you one more time if you want to review, I'll merge EOD today

[nonprofittechy]

Thanks, yes, this looks good to merge. Might still justify a major version bump in my opinion even if it won't literally break, since the new feature has a minimum version requirement. But I'm not expert on semver so open to your different interpretation.

[BryceStevenWilley]

To me breaking things is the key part of a major version bump. Definitely should be a minor version bump, and it's just a little more involved configuration than normal (agreed semver gets weird for libraries that can run different features on different versions of the base software though, it's not really made for that).