Add docs custom send button label & icon optional keyword args#904
Merged
nonprofittechy merged 2 commits intomainfrom Feb 12, 2025
Merged
Add docs custom send button label & icon optional keyword args#904nonprofittechy merged 2 commits intomainfrom
nonprofittechy merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
A couple issues with the tests:
|
Member
|
Black doesn't do a PR anymore. You need to do on command line. I'll ignore the kiln failure , but let's get this migrated to GitHub only testing! |
Collaborator
Author
|
Shall I just look up a run-of-the-mill tutorial on black, or are we doing anything special? |
e26d7f0 to
555ecd9
Compare
Member
Just pip install black, then black . |
nonprofittechy
approved these changes
Feb 12, 2025
Collaborator
Author
|
It's docsig main that seems to be failing at the moment [with "unknown option to disable 'E113'"]. If I have time today, I'll look into that. |
Member
|
We'll fix this in a separate PR. it looks like Docsig no longer supports the option to ignore error E113 (missing docstring). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #903, let author customize send button label and icon with keyword arguments. Added:
download_list_html()send_email_table_row()send_button_html()send_button_html()already had these options aslabelandicon.