Skip to content

Support DALazyTemplate in ALAddendumField #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nonprofittechy merged 7 commits into from
Nov 18, 2025
Merged

Support DALazyTemplate in ALAddendumField #988

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5cf9097
Fix #986 - make it possible to use a DALazyTemplate to allow a single…
nonprofittechy Nov 14, 2025
e5d5d19
Define content in test properly
LemmaLegal Nov 16, 2025
0e360d4
Use proper keyword param
LemmaLegal Nov 16, 2025
cd169a6
one more time - this test might not be possible
LemmaLegal Nov 16, 2025
97f234a
Testing DALazyTemplate isn't really possible without so much monkeypa…
LemmaLegal Nov 16, 2025
f33a289
Update docassemble/AssemblyLine/al_document.py
nonprofittechy Nov 18, 2025
c3242f5
Update docassemble/AssemblyLine/al_document.py
nonprofittechy Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docassemble/AssemblyLine/al_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
DAFile,
DAFileCollection,
DAFileList,
DALazyTemplate,
defined,
pdf_concatenate,
zip_file,
Expand Down Expand Up @@ -315,6 +316,9 @@ def overflow_value(

# If trigger is not a boolean value, overflow value is the value that starts at the end of the safe value.
original_value = self.value_if_defined()
# Ensure a DALazyTemplate is rendered to a string for downstream string ops
if isinstance(original_value, DALazyTemplate):
original_value = str(original_value)
safe_text = self.safe_value(
overflow_message=overflow_message,
input_width=input_width,
Expand Down Expand Up @@ -409,6 +413,9 @@ def has_overflow(
val = _original_value
else:
val = self.value_if_defined()
# If this is a template block, render it now so comparisons work correctly
if isinstance(val, DALazyTemplate):
val = str(val)

return (
self.safe_value(
Expand Down Expand Up @@ -508,6 +515,11 @@ def safe_value(
value = _original_value
else:
value = self.value_if_defined()

# Convert template blocks to strings for purposes of evaluating overflow
if isinstance(value, DALazyTemplate):
value = str(value)

if (
isinstance(value, str)
and len(value) <= self.overflow_trigger
Expand Down
Loading