Skip to content

Better internationalization possibilities within al_document.py #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nonprofittechy merged 6 commits into from
Nov 25, 2025
Merged

Better internationalization possibilities within al_document.py #992

nonprofittechy merged 6 commits into from
Nov 25, 2025

Conversation

@nonprofittechy
Copy link
Member

@nonprofittechy nonprofittechy commented Nov 20, 2025 •
edited
Loading

  1. Removes string caching for some user-visible phrases. Don't quite know why we did that to render a simple lazy template.
  2. Adds the ability to define Send, View, Download, Send to in XLSX translation file.
  3. Turns on translation in the test_al_document.yml and the test_question_library.yml files. These interview files aren't fully translated but this gives you the ability to run and see that the newly added strings are translated.

Fix #989

BryceStevenWilley
BryceStevenWilley approved these changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@BryceStevenWilley BryceStevenWilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nonprofittechy nonprofittechy merged commit 9ace47a into main Nov 25, 2025
8 checks passed
@nonprofittechy nonprofittechy deleted the internationalize-bundle branch November 25, 2025 21:36
BryceStevenWilley added a commit that referenced this pull request Dec 5, 2025
@BryceStevenWilley
Actually use .view_label and .download_label
6023414 
`action_button_html` expects a string for the label, and if it doesn't get it,
it just shows the default of "Edit". We started passing `DALazyTemplates` in
#992, and hadn't done enough testing to ensure that the labels shown there are
correct.

This patch fixes the issue by running the `DALazyTemplate` through `str()`
before passing to `action_button_html`.
@BryceStevenWilley BryceStevenWilley mentioned this pull request Dec 5, 2025
Merged
BryceStevenWilley added a commit that referenced this pull request Dec 5, 2025
@BryceStevenWilley
Actually use .view_label and .download_label
e127528 
`action_button_html` expects a string for the label, and if it doesn't get it,
it just shows the default of "Edit". We started passing `DALazyTemplates` in
#992, and hadn't done enough testing to ensure that the labels shown there are
correct.

This patch fixes the issue by running the `DALazyTemplate` through `str()`
before passing to `action_button_html`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BryceStevenWilley BryceStevenWilley BryceStevenWilley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate download_list_html hardcoded strings to use value() so we can make strings in XLSX file

3 participants

@nonprofittechy @BryceStevenWilley