Actually use .view_label and .download_label
#998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`action_button_html` expects a string for the label, and if it doesn't get it, it just shows the default of "Edit". We started passing `DALazyTemplates` in #992, and hadn't done enough testing to ensure that the labels shown there are correct. This patch fixes the issue by running the `DALazyTemplate` through `str()` before passing to `action_button_html`.
BryceStevenWilley
force-pushed
the
fix_labels
branch
from
6023414 to
e127528
Compare
nonprofittechy
approved these changes
Dec 5, 2025
Member
nonprofittechy
left a comment
nonprofittechy
left a comment
There was a problem hiding this comment.
Thanks for catching this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
action_button_htmlexpects a string for the label, and if it doesn't get it, it just shows the default of "Edit". We started passingDALazyTemplatesin #992, and hadn't done enough testing to ensure that the labels shown there are correct.This patch fixes the issue by running the
DALazyTemplatethroughstr()before passing toaction_button_html.Pre fix:
Post fix: