Add translations for ALToolbox ThreePartDate component #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For French, Spanish, Arabic, and Nepalese. Provided by Kelly McGuire!
Contributor
Author
|
This will check our tests; if the Kiln tests actually cover the birthdate question, they should fail (docassemble shows a full error screen without the linked ALToolbox PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For French, Spanish, Arabic, and Nepalese. Provided by Kelly McGuire!
We did have these translated strings already, but they were lowercase only, and the uppercase versions are used for the Month/Day/Year labels in the three-part date.
It needs SuffolkLITLab/docassemble-ALToolbox#317 to actually have any affect; by itself, it won't fix the translation issue, and will actually break the birthday question (as we give the custom data type new parameters that docassemble doesn't recognize).