Don't depend on `declaredType' #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceStevenWilley
force-pushed
the
avoid_declared_type
branch
from
e91771f to
42a6fd2
Compare
Directly couples us to the full java package namespace, which is not good (there have been refactors that are out in efile-test now that break the assumption that the package names won't change). Instead, use `name` (which is the XML Schema name), or just check that the `declaredType` contains the path we expect (those refactors only add to the namespace, not changing it entirely).
BryceStevenWilley
force-pushed
the
avoid_declared_type
branch
from
42a6fd2 to
1706083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly couples us to the full java package namespace, which is not good (there have been refactors that are out in efile-test now that break the assumption that the package names won't change) (SuffolkLITLab/EfileProxyServer#333)
Instead, use
name(which is the XML Schema name), or just check that thedeclaredTypecontains the path we expect (those refactors only add to the namespace, not changing it entirely).