Update Administration.php, use proper quoting for retrieveSettings#684
Open
raul-bns wants to merge 1 commit intoSuiteCRM:hotfixfrom
Open
Update Administration.php, use proper quoting for retrieveSettings#684raul-bns wants to merge 1 commit intoSuiteCRM:hotfixfrom
raul-bns wants to merge 1 commit intoSuiteCRM:hotfixfrom
Conversation
I found that the method retrieveSettings try to do a wrong quoted and then hardcode the quotes in the query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the method retrieveSettings try to do a wrong quoted and then hardcode the quotes in the query.
Description
I've change the way of handling the quotes for query in Adminstration.php
Motivation and Context
I've done that coz i was fixing some plugin and I've see it.
How To Test This
Types of changes
Final checklist