Add Meridian to Popup Datetime

[jack7anderson7]

Description

Add AM/ PM options on the datetime field.

Fix an issue where users with a +1 Timezone were seeing incorrect time on datetime field.

Motivation and Context

Add AM/PM on datetime.
Fix DST Issue on datetime.

How To Test This

1. Select a time format not in 24 hours
2. Go to a datetime field and see the AM/PM option

1. Select a timezone with DST and go through dates before and after DST ends
2. See the correct time.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[scicali]

May you check pull #654?
To calculate correct DST you need to use datetime from fronted/db field and not current datetime, I think.

[jack7anderson7]

Hi @scicali

Thank you for your contribution and your PR.

After analyzing this issue we found that there is a bug on the angular date formatting pipe:

• Datepipe formating with timezone - incorrect date in date when is winter time changed to summer time angular/angular#49540

Due to this we have decided to use luxon's DateTime formatting instead.

If you feel like there is something we may be missing, please let us know.

Kind Regards,
Jack