Update index.html, fix to could view it online for reference#4
Open
cautbur wants to merge 1 commit intoSuiteCRM:masterfrom
Open
Update index.html, fix to could view it online for reference#4cautbur wants to merge 1 commit intoSuiteCRM:masterfrom
cautbur wants to merge 1 commit intoSuiteCRM:masterfrom
Conversation
Update index.html, fix to could view it online for reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update index.html, fix to could view it online for reference
On documentation ther is a link for icon preview: https://docs.suitecrm.com/developer/theme/suitepiconsfont/create_suitepicon_font/, but if you follow it, icons are not showed because missing font. This fix is requested in order to could have it available for reference.
It could be ddone also adding to head section, but this only work if I also change all urls of @font-face prefixing with "./" in order to get relative paths. Since I don't tested if this will break the generation of final stylesheet, I have opted to embed it.
Regards.