Skip to content

source and app integrated doc template #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

source and app integrated doc template #3039

wants to merge 6 commits into from

Conversation

@JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Sep 5, 2023 •
edited by kimsauce
Loading

Purpose of this pull request

https://sumologic.atlassian.net/browse/DOCS-849

Select the type of change:

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions and updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@JV0812 JV0812 self-assigned this Sep 5, 2023
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 5, 2023
@JV0812 JV0812 added do-not-merge Pull requests that should not be merged and removed cla-signed Contributor approved, listed in .clabot file labels Sep 5, 2023
jpipkin1
jpipkin1 reviewed Sep 5, 2023
View reviewed changes
jpipkin1
jpipkin1 reviewed Sep 5, 2023
View reviewed changes
jpipkin1
jpipkin1 reviewed Sep 5, 2023
View reviewed changes
jpipkin1
jpipkin1 requested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @JV0812. I just had a few comments.

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Sep 6, 2023
@JV0812 JV0812 requested a review from jpipkin1 September 7, 2023 06:36
kimsauce

This comment was marked as resolved.

Sign in to view

@kimsauce kimsauce self-requested a review April 25, 2025 01:46
@soc-service-agent
Copy link

soc-service-agent commented Apr 25, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

kimsauce
kimsauce requested changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amee-sumo @JV0812 , please review and confirm if it's still needed. Looks like there's already a standalone template for c2c

@JV0812
Copy link
Collaborator Author

JV0812 commented Apr 28, 2025

Closing this ticket as we do not want to follow this approach to have an integrated C2C+app installation doc. Instead there is a change in UI and accordingly the app installation doc templates are updated.

@JV0812 JV0812 closed this Apr 28, 2025
@kimsauce kimsauce deleted the apps-and-integrations-doc-template branch July 15, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimsauce kimsauce kimsauce requested changes

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@stacykor stacykor Awaiting requested review from stacykor

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@JV0812 JV0812

@amee-sumo amee-sumo

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JV0812 @soc-service-agent @kimsauce @jpipkin1 @amee-sumo